Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3572)

Unified Diff: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc

Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-format Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
index 61f420c14805999e5fab3be688b221cfb57916fb..53e91c280ed28ea94fe3846014d07108b1a587d0 100644
--- a/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
@@ -15,7 +15,6 @@
#include "base/values.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/chromeos/camera_presence_notifier.h"
-#include "chrome/browser/chromeos/login/users/avatar/default_user_images.h"
#include "chrome/browser/chromeos/login/users/avatar/user_image_manager.h"
#include "chrome/browser/chromeos/login/users/user_manager.h"
#include "chrome/browser/chromeos/profiles/profile_helper.h"
@@ -26,6 +25,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/url_constants.h"
#include "chromeos/audio/chromeos_sounds.h"
+#include "components/user_manager/user_image/default_user_images.h"
#include "components/user_manager/user_image/user_image.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
@@ -166,14 +166,18 @@ void ChangePictureOptionsHandler::RegisterMessages() {
void ChangePictureOptionsHandler::SendDefaultImages() {
base::ListValue image_urls;
- for (int i = kFirstDefaultImageIndex; i < kDefaultImagesCount; ++i) {
+ for (int i = user_manager::kFirstDefaultImageIndex;
+ i < user_manager::kDefaultImagesCount;
+ ++i) {
scoped_ptr<base::DictionaryValue> image_data(new base::DictionaryValue);
- image_data->SetString("url", GetDefaultImageUrl(i));
+ image_data->SetString("url", user_manager::GetDefaultImageUrl(i));
image_data->SetString(
- "author", l10n_util::GetStringUTF16(kDefaultImageAuthorIDs[i]));
+ "author",
+ l10n_util::GetStringUTF16(user_manager::kDefaultImageAuthorIDs[i]));
image_data->SetString(
- "website", l10n_util::GetStringUTF16(kDefaultImageWebsiteIDs[i]));
- image_data->SetString("title", GetDefaultImageDescription(i));
+ "website",
+ l10n_util::GetStringUTF16(user_manager::kDefaultImageWebsiteIDs[i]));
+ image_data->SetString("title", user_manager::GetDefaultImageDescription(i));
image_urls.Append(image_data.release());
}
web_ui()->CallJavascriptFunction("ChangePictureOptions.setDefaultImages",
@@ -281,16 +285,17 @@ void ChangePictureOptionsHandler::SendSelectedImage() {
}
default: {
DCHECK(previous_image_index_ >= 0 &&
- previous_image_index_ < kDefaultImagesCount);
- if (previous_image_index_ >= kFirstDefaultImageIndex) {
+ previous_image_index_ < user_manager::kDefaultImagesCount);
+ if (previous_image_index_ >= user_manager::kFirstDefaultImageIndex) {
// User has image from the current set of default images.
- base::StringValue image_url(GetDefaultImageUrl(previous_image_index_));
+ base::StringValue image_url(
+ user_manager::GetDefaultImageUrl(previous_image_index_));
web_ui()->CallJavascriptFunction(
"ChangePictureOptions.setSelectedImage", image_url);
} else {
// User has an old default image, so present it in the same manner as a
// previous image from file.
- SendOldImage(GetDefaultImageUrl(previous_image_index_));
+ SendOldImage(user_manager::GetDefaultImageUrl(previous_image_index_));
}
}
}
@@ -348,17 +353,18 @@ void ChangePictureOptionsHandler::HandleSelectImage(
user_manager::UserImage::CreateAndEncode(previous_image_));
UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- kHistogramImageOld,
- kHistogramImagesCount);
+ user_manager::kHistogramImageOld,
+ user_manager::kHistogramImagesCount);
VLOG(1) << "Selected old user image";
} else if (image_type == "default" &&
- IsDefaultImageUrl(image_url, &image_index)) {
+ user_manager::IsDefaultImageUrl(image_url, &image_index)) {
// One of the default user images.
user_image_manager->SaveUserDefaultImageIndex(image_index);
- UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- GetDefaultImageHistogramValue(image_index),
- kHistogramImagesCount);
+ UMA_HISTOGRAM_ENUMERATION(
+ "UserImage.ChangeChoice",
+ user_manager::GetDefaultImageHistogramValue(image_index),
+ user_manager::kHistogramImagesCount);
VLOG(1) << "Selected default user image: " << image_index;
} else if (image_type == "camera") {
// Camera image is selected.
@@ -375,13 +381,13 @@ void ChangePictureOptionsHandler::HandleSelectImage(
if (previous_image_index_ == User::kProfileImageIndex) {
UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- kHistogramImageOld,
- kHistogramImagesCount);
+ user_manager::kHistogramImageOld,
+ user_manager::kHistogramImagesCount);
VLOG(1) << "Selected old (profile) user image";
} else {
UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- kHistogramImageFromProfile,
- kHistogramImagesCount);
+ user_manager::kHistogramImageFromProfile,
+ user_manager::kHistogramImagesCount);
VLOG(1) << "Selected profile image";
}
} else {
@@ -399,8 +405,9 @@ void ChangePictureOptionsHandler::FileSelected(const base::FilePath& path,
UserManager* user_manager = UserManager::Get();
user_manager->GetUserImageManager(GetUser()->email())->
SaveUserImageFromFile(path);
- UMA_HISTOGRAM_ENUMERATION(
- "UserImage.ChangeChoice", kHistogramImageFromFile, kHistogramImagesCount);
+ UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
+ user_manager::kHistogramImageFromFile,
+ user_manager::kHistogramImagesCount);
VLOG(1) << "Selected image from file";
}
@@ -410,8 +417,8 @@ void ChangePictureOptionsHandler::SetImageFromCamera(
user_manager->GetUserImageManager(GetUser()->email())
->SaveUserImage(user_manager::UserImage::CreateAndEncode(photo));
UMA_HISTOGRAM_ENUMERATION("UserImage.ChangeChoice",
- kHistogramImageFromCamera,
- kHistogramImagesCount);
+ user_manager::kHistogramImageFromCamera,
+ user_manager::kHistogramImagesCount);
VLOG(1) << "Selected camera photo";
}

Powered by Google App Engine
This is Rietveld 408576698