chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc - Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-format Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screens/user_image_screen.cc ('k') | chrome/browser/chromeos/login/users/avatar/default_user_images.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

index 1c519d4305e56926f5212e22c86e30ae3ce0a81f..e8d4c240b0483ee1c674bde1dec4292b87d372c2 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

@@ -458,7 +458,8 @@ void SupervisedUserCreationScreen::ApplyPicture() {

NOTREACHED() << "Supervised users have no profile pictures";

break;

default:

- DCHECK(selected_image_ >= 0 && selected_image_ < kDefaultImagesCount);

+ DCHECK(selected_image_ >= 0 &&

+ selected_image_ < user_manager::kDefaultImagesCount);

image_manager->SaveUserDefaultImageIndex(selected_image_);

break;

}

@@ -502,14 +503,16 @@ void SupervisedUserCreationScreen::OnGetSupervisedUsers(

!chromeos_avatar.empty() &&

SupervisedUserSyncService::GetAvatarIndex(

chromeos_avatar, &avatar_index)) {

- ui_copy->SetString(kAvatarURLKey, GetDefaultImageUrl(avatar_index));

+ ui_copy->SetString(kAvatarURLKey,

+ user_manager::GetDefaultImageUrl(avatar_index));

} else {

- int i = base::RandInt(kFirstDefaultImageIndex, kDefaultImagesCount - 1);

+ int i = base::RandInt(user_manager::kFirstDefaultImageIndex,

+ user_manager::kDefaultImagesCount - 1);

local_copy->SetString(

SupervisedUserSyncService::kChromeOsAvatar,

SupervisedUserSyncService::BuildAvatarString(i));

local_copy->SetBoolean(kRandomAvatarKey, true);

- ui_copy->SetString(kAvatarURLKey, GetDefaultImageUrl(i));

+ ui_copy->SetString(kAvatarURLKey, user_manager::GetDefaultImageUrl(i));

}

local_copy->SetBoolean(kUserExists, false);

@@ -581,7 +584,7 @@ void SupervisedUserCreationScreen::OnImageSelected(

return;

int user_image_index = User::kInvalidImageIndex;

if (image_type == "default" &&

- IsDefaultImageUrl(image_url, &user_image_index)) {

+ user_manager::IsDefaultImageUrl(image_url, &user_image_index)) {

selected_image_ = user_image_index;

} else if (image_type == "camera") {

selected_image_ = User::kExternalImageIndex;