chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc - Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-format Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h ('k') | chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

index 5f3d36b10e34b459454f724bb99591ee24368fc6..60ffdaf107fce0e8b28f64a891492c839c3df9b8 100644

--- a/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

@@ -390,14 +390,18 @@ void SupervisedUserCreationScreenHandler::HandleAuthenticateManager(

// It should be removed by issue 251179.

void SupervisedUserCreationScreenHandler::HandleGetImages() {

base::ListValue image_urls;

- for (int i = kFirstDefaultImageIndex; i < kDefaultImagesCount; ++i) {

+ for (int i = user_manager::kFirstDefaultImageIndex;

+ i < user_manager::kDefaultImagesCount;

+ ++i) {

scoped_ptr<base::DictionaryValue> image_data(new base::DictionaryValue);

- image_data->SetString("url", GetDefaultImageUrl(i));

+ image_data->SetString("url", user_manager::GetDefaultImageUrl(i));

image_data->SetString(

- "author", l10n_util::GetStringUTF16(kDefaultImageAuthorIDs[i]));

+ "author",

+ l10n_util::GetStringUTF16(user_manager::kDefaultImageAuthorIDs[i]));

image_data->SetString(

- "website", l10n_util::GetStringUTF16(kDefaultImageWebsiteIDs[i]));

- image_data->SetString("title", GetDefaultImageDescription(i));

+ "website",

+ l10n_util::GetStringUTF16(user_manager::kDefaultImageWebsiteIDs[i]));

+ image_data->SetString("title", user_manager::GetDefaultImageDescription(i));

image_urls.Append(image_data.release());

}

CallJS("setDefaultImages", image_urls);