Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). In preparation for migrating to TimeSource, StartPlayingFrom() is renamed to StartPlaying() with renderers expected to fetch the current time instead of being provided the time. AudioRenderer::SetMediaTime() is temporarily added until we can migrate the interface to being based on TimeSource. BUG=370634 R=xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284155

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -59 lines) Patch
M media/base/audio_renderer.h View 1 2 chunks +11 lines, -2 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/pipeline.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M media/base/pipeline_unittest.cc View 7 chunks +17 lines, -13 lines 0 comments Download
M media/base/video_renderer.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/filters/audio_renderer_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/audio_renderer_impl.cc View 3 chunks +13 lines, -4 lines 0 comments Download
M media/filters/audio_renderer_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/video_renderer_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_renderer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_renderer_impl_unittest.cc View 1 11 chunks +27 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
xhwang: here's another piece split off from my initial TimeSource prototype CL [1] basically we ...
6 years, 5 months ago (2014-07-18 00:36:18 UTC) #1
scherkus (not reviewing)
https://codereview.chromium.org/400853002/diff/1/media/filters/audio_renderer_impl.h File media/filters/audio_renderer_impl.h (right): https://codereview.chromium.org/400853002/diff/1/media/filters/audio_renderer_impl.h#newcode101 media/filters/audio_renderer_impl.h:101: // | StartPlayingFrom() ^ note to self: update comments ...
6 years, 5 months ago (2014-07-18 00:54:56 UTC) #2
xhwang
lgtm % tiny nit https://codereview.chromium.org/400853002/diff/1/media/base/audio_renderer.h File media/base/audio_renderer.h (right): https://codereview.chromium.org/400853002/diff/1/media/base/audio_renderer.h#newcode62 media/base/audio_renderer.h:62: // currently .rendering. remove extra ...
6 years, 5 months ago (2014-07-18 04:56:45 UTC) #3
scherkus (not reviewing)
https://codereview.chromium.org/400853002/diff/1/media/base/audio_renderer.h File media/base/audio_renderer.h (right): https://codereview.chromium.org/400853002/diff/1/media/base/audio_renderer.h#newcode62 media/base/audio_renderer.h:62: // currently .rendering. On 2014/07/18 04:56:44, xhwang wrote: > ...
6 years, 5 months ago (2014-07-18 15:29:30 UTC) #4
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-18 15:29:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/400853002/40001
6 years, 5 months ago (2014-07-18 15:30:29 UTC) #6
scherkus (not reviewing)
6 years, 5 months ago (2014-07-18 18:02:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r284155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698