media/base/pipeline.cc - Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/pipeline.cc

Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/pipeline.cc

diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc

index ca53be0ceb874e7e567c0c6c831d425bd76b1329..e1af61130aa392b5c7d4f00cb5821a4afe861b0d 100644

--- a/media/base/pipeline.cc

+++ b/media/base/pipeline.cc

@@ -402,10 +402,12 @@ void Pipeline::StateTransitionTask(PipelineStatus status) {

interpolator_->SetBounds(start_timestamp_, start_timestamp_);

}

- if (audio_renderer_)

- audio_renderer_->StartPlayingFrom(start_timestamp_);

+ if (audio_renderer_) {

+ audio_renderer_->SetMediaTime(start_timestamp_);

+ audio_renderer_->StartPlaying();

+ }

if (video_renderer_)

- video_renderer_->StartPlayingFrom(start_timestamp_);

+ video_renderer_->StartPlaying();

if (text_renderer_)

text_renderer_->StartPlaying();

« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline_unittest.cc » ('j') | no next file with comments »