media/filters/video_renderer_impl.h - Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_impl.h

Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/video_renderer_impl.h

diff --git a/media/filters/video_renderer_impl.h b/media/filters/video_renderer_impl.h

index 06262dadf4348a4ae5e9a6d019c7bd1d54fc17a5..9f3b6715c203e4a1306cd7dbb298d2de76065afa 100644

--- a/media/filters/video_renderer_impl.h

+++ b/media/filters/video_renderer_impl.h

@@ -68,7 +68,7 @@ class MEDIA_EXPORT VideoRendererImpl

const TimeDeltaCB& get_time_cb,

const TimeDeltaCB& get_duration_cb) OVERRIDE;

virtual void Flush(const base::Closure& callback) OVERRIDE;

- virtual void StartPlayingFrom(base::TimeDelta timestamp) OVERRIDE;

+ virtual void StartPlaying() OVERRIDE;

virtual void Stop(const base::Closure& callback) OVERRIDE;

// PlatformThread::Delegate implementation.

@@ -155,7 +155,7 @@ class MEDIA_EXPORT VideoRendererImpl

// |

// V Decoders reset

// kFlushed <------------------ kFlushing

- // | StartPlayingFrom() ^

+ // | StartPlaying() ^

// | |

// | | Flush()

// `---------> kPlaying --------'

« no previous file with comments | « media/filters/audio_renderer_impl_unittest.cc ('k') | media/filters/video_renderer_impl.cc » ('j') | no next file with comments »