Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: media/filters/video_renderer_impl.h

Issue 400853002: Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_ 5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
6 #define MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_ 6 #define MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 bool low_delay, 61 bool low_delay,
62 const PipelineStatusCB& init_cb, 62 const PipelineStatusCB& init_cb,
63 const StatisticsCB& statistics_cb, 63 const StatisticsCB& statistics_cb,
64 const TimeCB& max_time_cb, 64 const TimeCB& max_time_cb,
65 const BufferingStateCB& buffering_state_cb, 65 const BufferingStateCB& buffering_state_cb,
66 const base::Closure& ended_cb, 66 const base::Closure& ended_cb,
67 const PipelineStatusCB& error_cb, 67 const PipelineStatusCB& error_cb,
68 const TimeDeltaCB& get_time_cb, 68 const TimeDeltaCB& get_time_cb,
69 const TimeDeltaCB& get_duration_cb) OVERRIDE; 69 const TimeDeltaCB& get_duration_cb) OVERRIDE;
70 virtual void Flush(const base::Closure& callback) OVERRIDE; 70 virtual void Flush(const base::Closure& callback) OVERRIDE;
71 virtual void StartPlayingFrom(base::TimeDelta timestamp) OVERRIDE; 71 virtual void StartPlaying() OVERRIDE;
72 virtual void Stop(const base::Closure& callback) OVERRIDE; 72 virtual void Stop(const base::Closure& callback) OVERRIDE;
73 73
74 // PlatformThread::Delegate implementation. 74 // PlatformThread::Delegate implementation.
75 virtual void ThreadMain() OVERRIDE; 75 virtual void ThreadMain() OVERRIDE;
76 76
77 private: 77 private:
78 // Callback for |video_frame_stream_| initialization. 78 // Callback for |video_frame_stream_| initialization.
79 void OnVideoFrameStreamInitialized(bool success); 79 void OnVideoFrameStreamInitialized(bool success);
80 80
81 // Callback for |video_frame_stream_| to deliver decoded video frames and 81 // Callback for |video_frame_stream_| to deliver decoded video frames and
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 // 148 //
149 // kUninitialized 149 // kUninitialized
150 // | Initialize() 150 // | Initialize()
151 // | 151 // |
152 // V 152 // V
153 // kInitializing 153 // kInitializing
154 // | Decoders initialized 154 // | Decoders initialized
155 // | 155 // |
156 // V Decoders reset 156 // V Decoders reset
157 // kFlushed <------------------ kFlushing 157 // kFlushed <------------------ kFlushing
158 // | StartPlayingFrom() ^ 158 // | StartPlayingFrom() ^
scherkus (not reviewing) 2014/07/18 00:54:56 note to self: update comments
scherkus (not reviewing) 2014/07/18 15:29:30 Done.
159 // | | 159 // | |
160 // | | Flush() 160 // | | Flush()
161 // `---------> kPlaying --------' 161 // `---------> kPlaying --------'
162 enum State { 162 enum State {
163 kUninitialized, 163 kUninitialized,
164 kInitializing, 164 kInitializing,
165 kFlushing, 165 kFlushing,
166 kFlushed, 166 kFlushed,
167 kPlaying, 167 kPlaying,
168 kStopped, 168 kStopped,
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 210
211 // NOTE: Weak pointers must be invalidated before all other member variables. 211 // NOTE: Weak pointers must be invalidated before all other member variables.
212 base::WeakPtrFactory<VideoRendererImpl> weak_factory_; 212 base::WeakPtrFactory<VideoRendererImpl> weak_factory_;
213 213
214 DISALLOW_COPY_AND_ASSIGN(VideoRendererImpl); 214 DISALLOW_COPY_AND_ASSIGN(VideoRendererImpl);
215 }; 215 };
216 216
217 } // namespace media 217 } // namespace media
218 218
219 #endif // MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_ 219 #endif // MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698