Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 400633003: DevTools: introduce multitarget model listeners (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
Reviewers:
apavlov, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: introduce multitarget model listeners NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178447

Patch Set 1 : #

Total comments: 16

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -274 lines) Patch
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html View 1 1 chunk +4 lines, -10 lines 0 comments Download
M Source/devtools/front_end/ScreencastView.js View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 2 chunks +2 lines, -20 lines 0 comments Download
M Source/devtools/front_end/components/ExecutionContextSelector.js View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionServer.js View 1 3 chunks +24 lines, -7 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +3 lines, -41 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 3 chunks +8 lines, -17 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileView.js View 2 chunks +2 lines, -20 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/CPUProfilerModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/ConsoleModel.js View 5 chunks +5 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMStorage.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Database.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/HeapProfilerModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkManager.js View 3 chunks +3 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js View 2 chunks +5 lines, -27 lines 0 comments Download
M Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js View 2 chunks +3 lines, -22 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/RuntimeModel.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 6 chunks +83 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +7 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pfeldman
6 years, 5 months ago (2014-07-17 21:41:14 UTC) #1
apavlov
I've just done a high-level scan through Target.js, no detailed review :( https://codereview.chromium.org/400633003/diff/40001/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js ...
6 years, 5 months ago (2014-07-17 22:09:59 UTC) #2
pfeldman
https://codereview.chromium.org/400633003/diff/40001/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/400633003/diff/40001/Source/devtools/front_end/sdk/Target.js#newcode254 Source/devtools/front_end/sdk/Target.js:254: On 2014/07/17 22:09:59, apavlov wrote: > extra line Done. ...
6 years, 5 months ago (2014-07-18 11:59:47 UTC) #3
sergeyv
lgtm
6 years, 5 months ago (2014-07-18 12:50:34 UTC) #4
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-18 14:55:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/400633003/60001
6 years, 5 months ago (2014-07-18 14:55:38 UTC) #6
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-18 15:05:58 UTC) #7
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-18 15:06:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/400633003/60001
6 years, 5 months ago (2014-07-18 15:06:06 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 15:06:48 UTC) #10
Message was sent while issue was closed. 
Change committed as 178447

Powered by Google App Engine
This is Rietveld 408576698