Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: Source/devtools/front_end/main/Main.js

Issue 400633003: DevTools: introduce multitarget model listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/main/Main.js
diff --git a/Source/devtools/front_end/main/Main.js b/Source/devtools/front_end/main/Main.js
index 5027863952ca96353bd4e91408df1fe8d1757bd2..0ac884f12643b023d72955db8949f37daecae830 100644
--- a/Source/devtools/front_end/main/Main.js
+++ b/Source/devtools/front_end/main/Main.js
@@ -858,73 +858,35 @@ WebInspector.Main.WarningErrorCounter.prototype = {
/**
* @constructor
- * @implements {WebInspector.TargetManager.Observer}
*/
WebInspector.Main.PauseListener = function()
{
- WebInspector.targetManager.observeTargets(this);
+ WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.DebuggerPaused, this._debuggerPaused, this);
}
WebInspector.Main.PauseListener.prototype = {
/**
- * @param {!WebInspector.Target} target
- */
- targetAdded: function(target)
- {
- target.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.DebuggerPaused, this._debuggerPaused, this);
- },
-
- /**
- * @param {!WebInspector.Target} target
- */
- targetRemoved: function(target)
- {
- target.debuggerModel.removeEventListener(WebInspector.DebuggerModel.Events.DebuggerPaused, this._debuggerPaused, this);
- },
-
- /**
* @param {!WebInspector.Event} event
*/
_debuggerPaused: function(event)
{
- var targets = WebInspector.targetManager.targets();
- for (var i = 0; i < targets.length; ++i)
- targets[i].debuggerModel.removeEventListener(WebInspector.DebuggerModel.Events.DebuggerPaused, this._debuggerPaused, this);
-
+ WebInspector.targetManager.removeModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.DebuggerPaused, this._debuggerPaused, this);
var debuggerModel = /** @type {!WebInspector.DebuggerModel} */ (event.target);
WebInspector.context.setFlavor(WebInspector.Target, debuggerModel.target());
- WebInspector.targetManager.unobserveTargets(this);
WebInspector.inspectorView.showPanel("sources");
}
}
/**
* @constructor
- * @implements {WebInspector.TargetManager.Observer}
*/
WebInspector.Main.InspectedNodeRevealer = function()
{
- WebInspector.targetManager.observeTargets(this);
+ WebInspector.targetManager.addModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.NodeInspected, this._inspectNode, this);
}
WebInspector.Main.InspectedNodeRevealer.prototype = {
/**
- * @param {!WebInspector.Target} target
- */
- targetAdded: function(target)
- {
- target.domModel.addEventListener(WebInspector.DOMModel.Events.NodeInspected, this._inspectNode, this);
- },
-
- /**
- * @param {!WebInspector.Target} target
- */
- targetRemoved: function(target)
- {
- target.domModel.removeEventListener(WebInspector.DOMModel.Events.NodeInspected, this._inspectNode, this);
- },
-
- /**
* @param {!WebInspector.Event} event
*/
_inspectNode: function(event)
« no previous file with comments | « Source/devtools/front_end/extensions/ExtensionServer.js ('k') | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698