Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js

Issue 400633003: DevTools: introduce multitarget model listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js
diff --git a/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js b/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js
index 2313ceb98aae3b14758e47e03968bbd4c3ffe8de..2486dfa0f5e23a375edf72b349cf84381e101366 100644
--- a/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js
+++ b/Source/devtools/front_end/sdk/NetworkUISourceCodeProvider.js
@@ -30,7 +30,6 @@
/**
* @constructor
- * @implements {WebInspector.TargetManager.Observer}
* @param {!WebInspector.NetworkWorkspaceBinding} networkWorkspaceBinding
* @param {!WebInspector.Workspace} workspace
*/
@@ -38,39 +37,18 @@ WebInspector.NetworkUISourceCodeProvider = function(networkWorkspaceBinding, wor
{
this._networkWorkspaceBinding = networkWorkspaceBinding;
this._workspace = workspace;
- WebInspector.targetManager.observeTargets(this);
this._processedURLs = {};
+ WebInspector.targetManager.addModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, this._resourceAdded, this);
+ WebInspector.targetManager.addModelListener(WebInspector.ResourceTreeModel, WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._mainFrameNavigated, this);
+ WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.ParsedScriptSource, this._parsedScriptSource, this);
+ WebInspector.targetManager.addModelListener(WebInspector.DebuggerModel, WebInspector.DebuggerModel.Events.FailedToParseScriptSource, this._parsedScriptSource, this);
+ WebInspector.targetManager.addModelListener(WebInspector.CSSStyleModel, WebInspector.CSSStyleModel.Events.StyleSheetAdded, this._styleSheetAdded, this);
}
WebInspector.NetworkUISourceCodeProvider.prototype = {
/**
* @param {!WebInspector.Target} target
*/
- targetAdded: function(target)
- {
- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, this._resourceAdded, this);
- target.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._mainFrameNavigated, this);
- target.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, this._parsedScriptSource, this);
- target.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.FailedToParseScriptSource, this._parsedScriptSource, this);
- target.cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetAdded, this._styleSheetAdded, this);
- },
-
- /**
- * @param {!WebInspector.Target} target
- */
- targetRemoved: function(target)
- {
- // FIXME: add workspace cleanup here.
- target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, this._resourceAdded, this);
- target.resourceTreeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.MainFrameNavigated, this._mainFrameNavigated, this);
- target.debuggerModel.removeEventListener(WebInspector.DebuggerModel.Events.ParsedScriptSource, this._parsedScriptSource, this);
- target.debuggerModel.removeEventListener(WebInspector.DebuggerModel.Events.FailedToParseScriptSource, this._parsedScriptSource, this);
- target.cssModel.removeEventListener(WebInspector.CSSStyleModel.Events.StyleSheetAdded, this._styleSheetAdded, this);
- },
-
- /**
- * @param {!WebInspector.Target} target
- */
_populate: function(target)
{
/**
« no previous file with comments | « Source/devtools/front_end/sdk/NetworkManager.js ('k') | Source/devtools/front_end/sdk/PresentationConsoleMessageHelper.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698