Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: Source/devtools/front_end/sdk/ConsoleModel.js

Issue 400633003: DevTools: introduce multitarget model listeners (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/CSSStyleModel.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/ConsoleModel.js
diff --git a/Source/devtools/front_end/sdk/ConsoleModel.js b/Source/devtools/front_end/sdk/ConsoleModel.js
index da7dc89cbdd83a21abdf2c12177212aae029a2b0..6c559ba5df63b2c55e46d8e94a55501f8c312e6d 100644
--- a/Source/devtools/front_end/sdk/ConsoleModel.js
+++ b/Source/devtools/front_end/sdk/ConsoleModel.js
@@ -30,12 +30,12 @@
/**
* @constructor
- * @extends {WebInspector.SDKObject}
+ * @extends {WebInspector.SDKModel}
* @param {!WebInspector.Target} target
*/
WebInspector.ConsoleModel = function(target)
{
- WebInspector.SDKObject.call(this, target);
+ WebInspector.SDKModel.call(this, WebInspector.ConsoleModel, target);
/** @type {!Array.<!WebInspector.ConsoleMessage>} */
this._messages = [];
@@ -130,7 +130,7 @@ WebInspector.ConsoleModel.prototype = {
this.dispatchEventToListeners(WebInspector.ConsoleModel.Events.ConsoleCleared);
},
- __proto__: WebInspector.SDKObject.prototype
+ __proto__: WebInspector.SDKModel.prototype
}
/**
@@ -474,6 +474,8 @@ WebInspector.ConsoleDispatcher.prototype = {
WebInspector.MultitargetConsoleModel = function()
{
WebInspector.targetManager.observeTargets(this);
+ WebInspector.targetManager.addModelListener(WebInspector.ConsoleModel, WebInspector.ConsoleModel.Events.MessageAdded, this._consoleMessageAdded, this);
+ WebInspector.targetManager.addModelListener(WebInspector.ConsoleModel, WebInspector.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
}
WebInspector.MultitargetConsoleModel.prototype = {
@@ -486,8 +488,6 @@ WebInspector.MultitargetConsoleModel.prototype = {
this._mainTarget = target;
target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);
}
- target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded, this._consoleMessageAdded, this);
- target.consoleModel.addEventListener(WebInspector.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
},
/**
@@ -499,8 +499,6 @@ WebInspector.MultitargetConsoleModel.prototype = {
delete this._mainTarget;
target.consoleModel.removeEventListener(WebInspector.ConsoleModel.Events.ConsoleCleared, this._consoleCleared, this);
}
- target.consoleModel.removeEventListener(WebInspector.ConsoleModel.Events.MessageAdded, this._consoleMessageAdded, this);
- target.consoleModel.removeEventListener(WebInspector.ConsoleModel.Events.CommandEvaluated, this._commandEvaluated, this);
},
/**
« no previous file with comments | « Source/devtools/front_end/sdk/CSSStyleModel.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698