Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 397803004: Reimplement QuicCryptoClientStream::WasChannelIDSent with a boolean (Closed)

Created:
6 years, 5 months ago by wtc
Modified:
6 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reimplement QuicCryptoClientStream::WasChannelIDSent with a boolean member so we can free channel_id_key_ after we're finished with it. This fixes a TODO in https://codereview.chromium.org/355293003/. R=rch@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283569

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M net/quic/quic_client_session_test.cc View 2 chunks +1 line, -15 lines 0 comments Download
M net/quic/quic_crypto_client_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 3 chunks +3 lines, -3 lines 1 comment Download
M net/quic/test_tools/quic_client_session_peer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_client_session_peer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
https://codereview.chromium.org/397803004/diff/1/net/quic/quic_crypto_client_stream.cc File net/quic/quic_crypto_client_stream.cc (right): https://codereview.chromium.org/397803004/diff/1/net/quic/quic_crypto_client_stream.cc#newcode194 net/quic/quic_crypto_client_stream.cc:194: channel_id_key_.get(), If channel_id_key_.get() is not null, crypto_config_->FillClientHello will send ...
6 years, 5 months ago (2014-07-16 02:01:27 UTC) #1
Ryan Hamilton
lgtm Nice cleanup!
6 years, 5 months ago (2014-07-16 15:59:16 UTC) #2
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 5 months ago (2014-07-16 16:40:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/397803004/1
6 years, 5 months ago (2014-07-16 16:43:04 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 23:18:00 UTC) #5
Message was sent while issue was closed.
Change committed as 283569

Powered by Google App Engine
This is Rietveld 408576698