Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: net/quic/quic_client_session_test.cc

Issue 397803004: Reimplement QuicCryptoClientStream::WasChannelIDSent with a boolean (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_crypto_client_stream.h » ('j') | net/quic/quic_crypto_client_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session_test.cc
diff --git a/net/quic/quic_client_session_test.cc b/net/quic/quic_client_session_test.cc
index d93ecd3100a73d3aeae3c912b4aec86e597be94e..f15e695dd08b654405ae0f53c7d8f495675106e3 100644
--- a/net/quic/quic_client_session_test.cc
+++ b/net/quic/quic_client_session_test.cc
@@ -66,20 +66,6 @@ class TestPacketWriter : public QuicDefaultPacketWriter {
QuicPacketHeader header_;
};
-class FakeChannelIDKey : public ChannelIDKey {
- public:
- // ChannelIDKey implementation
- virtual bool Sign(base::StringPiece signed_data,
- std::string* out_signature) const OVERRIDE {
- *out_signature = "";
- return true;
- }
-
- virtual std::string SerializeKey() const OVERRIDE {
- return "";
- }
-};
-
class QuicClientSessionTest : public ::testing::TestWithParam<QuicVersion> {
protected:
QuicClientSessionTest()
@@ -223,7 +209,7 @@ TEST_P(QuicClientSessionTest, ConnectionPooledWithTlsChannelId) {
session_.OnProofVerifyDetailsAvailable(details);
CompleteCryptoHandshake();
- QuicClientSessionPeer::SetChannelIDKey(&session_, new FakeChannelIDKey);
+ QuicClientSessionPeer::SetChannelIDSent(&session_, true);
EXPECT_TRUE(session_.CanPool("www.example.org"));
EXPECT_TRUE(session_.CanPool("mail.example.org"));
« no previous file with comments | « no previous file | net/quic/quic_crypto_client_stream.h » ('j') | net/quic/quic_crypto_client_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698