Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 355293003: Restrict QUIC session pool when channel ID is present. (Closed)

Created:
6 years, 5 months ago by Ryan Hamilton
Modified:
6 years, 5 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Restrict QUIC session pool when channel ID is present. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280963

Patch Set 1 #

Total comments: 12

Patch Set 2 : Fix comments #

Total comments: 26

Patch Set 3 : Fix comments #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -11 lines) Patch
M net/quic/quic_client_session.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 2 5 chunks +22 lines, -8 lines 4 comments Download
M net/quic/quic_client_session_test.cc View 1 2 5 chunks +66 lines, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_client_session_peer.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_client_session_peer.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
wtc
Patch set 1 LGTM. https://codereview.chromium.org/355293003/diff/1/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/355293003/diff/1/net/quic/quic_client_session.cc#newcode498 net/quic/quic_client_session.cc:498: ssl_info.cert->VerifyNameMatch(hostname, &unused); Nit: a comment ...
6 years, 5 months ago (2014-06-27 23:55:51 UTC) #1
Ryan Hamilton
I believe I have implemented that last piece of missing functionality in GetSSLInfo, and have ...
6 years, 5 months ago (2014-07-01 18:37:17 UTC) #2
wtc
Patch set 2 LGTM. https://codereview.chromium.org/355293003/diff/1/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/355293003/diff/1/net/quic/quic_client_session.cc#newcode498 net/quic/quic_client_session.cc:498: ssl_info.cert->VerifyNameMatch(hostname, &unused); On 2014/07/01 18:37:17, ...
6 years, 5 months ago (2014-07-01 23:00:15 UTC) #3
Ryan Hamilton
Thanks! Great comments. https://codereview.chromium.org/355293003/diff/1/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/355293003/diff/1/net/quic/quic_client_session.cc#newcode498 net/quic/quic_client_session.cc:498: ssl_info.cert->VerifyNameMatch(hostname, &unused); On 2014/07/01 23:00:14, wtc ...
6 years, 5 months ago (2014-07-01 23:26:20 UTC) #4
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 5 months ago (2014-07-01 23:26:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/355293003/40001
6 years, 5 months ago (2014-07-01 23:27:42 UTC) #6
wtc
Patch set 3 LGTM. You or I can fix the comment nit later. Thanks! https://codereview.chromium.org/355293003/diff/40001/net/quic/quic_client_session.cc ...
6 years, 5 months ago (2014-07-02 00:18:54 UTC) #7
wtc
https://codereview.chromium.org/355293003/diff/40001/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/355293003/diff/40001/net/quic/quic_client_session.cc#newcode494 net/quic/quic_client_session.cc:494: // hosts are from different eTLDs. And of course, ...
6 years, 5 months ago (2014-07-02 00:47:48 UTC) #8
commit-bot: I haz the power
Change committed as 280963
6 years, 5 months ago (2014-07-02 07:15:18 UTC) #9
Ryan Hamilton
6 years, 5 months ago (2014-07-02 19:46:38 UTC) #10
Message was sent while issue was closed.
Thanks!

https://codereview.chromium.org/355293003/diff/40001/net/quic/quic_client_ses...
File net/quic/quic_client_session.cc (right):

https://codereview.chromium.org/355293003/diff/40001/net/quic/quic_client_ses...
net/quic/quic_client_session.cc:494: // hosts are from different eTLDs. And of
course, it is prohibited
On 2014/07/02 00:47:48, wtc wrote:
> 
> I just realized one error: this should be "domains" instead of "eTLDs". eTLDs
> are "com", "co.uk", etc. But what you have in mind is "google.com",
> "google.co.uk", etc.

Actually eTLD+1 because it's ok to pool i1.foo.google.com and i2.bar.google.com.
 Fixed in https://codereview.chromium.org/362323005.

https://codereview.chromium.org/355293003/diff/40001/net/quic/quic_client_ses...
net/quic/quic_client_session.cc:495: // if the server cert is not valid for the
new domain.
On 2014/07/02 00:18:54, wtc wrote:
> 
> Nit: reorder the comments or the three tests so that they match. Right now the
> last sentence in the comments describes the first test.

Done in https://codereview.chromium.org/362323005.

Powered by Google App Engine
This is Rietveld 408576698