Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 397803004: Reimplement QuicCryptoClientStream::WasChannelIDSent with a boolean (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_crypto_client_stream.h ('k') | net/quic/test_tools/quic_client_session_peer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_client_stream.cc
diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc
index f3a924b9ef4770b4f6dc9b996ac1155ee2dcd9a8..19f3cec25bb014b526163e894ce0537d835c31a0 100644
--- a/net/quic/quic_crypto_client_stream.cc
+++ b/net/quic/quic_crypto_client_stream.cc
@@ -78,6 +78,7 @@ QuicCryptoClientStream::QuicCryptoClientStream(
crypto_config_(crypto_config),
server_id_(server_id),
generation_counter_(0),
+ channel_id_sent_(false),
channel_id_source_callback_(NULL),
verify_context_(verify_context),
proof_verify_callback_(NULL) {
@@ -110,9 +111,7 @@ int QuicCryptoClientStream::num_sent_client_hellos() const {
}
bool QuicCryptoClientStream::WasChannelIDSent() const {
- // TODO(rch): we should replace this with a boolean member so we
- // can free the memory associated with the key after we're finished with it.
- return channel_id_key_.get() != NULL;
+ return channel_id_sent_;
}
// kMaxClientHellos is the maximum number of times that we'll send a client
@@ -203,6 +202,7 @@ void QuicCryptoClientStream::DoHandshakeLoop(
CloseConnectionWithDetails(error, error_details);
return;
}
+ channel_id_sent_ = (channel_id_key_.get() != NULL);
if (cached->proof_verify_details()) {
client_session()->OnProofVerifyDetailsAvailable(
*cached->proof_verify_details());
« no previous file with comments | « net/quic/quic_crypto_client_stream.h ('k') | net/quic/test_tools/quic_client_session_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698