Issue 3966007: Fix save file stuff to use scoped_refptr for refcounted params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3966007: Fix save file stuff to use scoped_refptr for refcounted params. (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
Randy Smith (Not in Mondays), Paweł Hajdan Jr.

CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix save file stuff to use scoped_refptr for refcounted params. BUG=28083 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63748

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -6 lines)			Patch
M	chrome/browser/download/save_file_manager.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/download/save_package.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/save_file_resource_handler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Paweł Hajdan Jr.

Assuming there are no leaks / use-after-free issues after applying this, LGTM. I don't fully ...

10 years, 2 months ago (2010-10-25 16:52:41 UTC) #2

willchan no longer on Chromium

NewRunnableMethod() uses templating to generate the Params which is stored in the Task subtype as ...

10 years, 2 months ago (2010-10-25 17:06:48 UTC) #3

Randy Smith (Not in Mondays)

10 years, 2 months ago (2010-10-25 17:14:16 UTC) #4

On 2010/10/23 00:11:37, willchan wrote:
> 

LGTM.  Nice work.