Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/download/save_package.cc

Issue 3966007: Fix save file stuff to use scoped_refptr for refcounted params. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/download/save_package.h" 5 #include "chrome/browser/download/save_package.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/file_path.h" 8 #include "base/file_path.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/i18n/file_util_icu.h" 10 #include "base/i18n/file_util_icu.h"
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 } 1018 }
1019 1019
1020 SaveUrlItemMap::iterator it = in_progress_items_.find(frame_url.spec()); 1020 SaveUrlItemMap::iterator it = in_progress_items_.find(frame_url.spec());
1021 if (it == in_progress_items_.end()) 1021 if (it == in_progress_items_.end())
1022 return; 1022 return;
1023 SaveItem* save_item = it->second; 1023 SaveItem* save_item = it->second;
1024 DCHECK(save_item->save_source() == SaveFileCreateInfo::SAVE_FILE_FROM_DOM); 1024 DCHECK(save_item->save_source() == SaveFileCreateInfo::SAVE_FILE_FROM_DOM);
1025 1025
1026 if (!data.empty()) { 1026 if (!data.empty()) {
1027 // Prepare buffer for saving HTML data. 1027 // Prepare buffer for saving HTML data.
1028 net::IOBuffer* new_data = new net::IOBuffer(data.size()); 1028 scoped_refptr<net::IOBuffer> new_data(new net::IOBuffer(data.size()));
1029 new_data->AddRef(); // We'll pass the buffer to SaveFileManager.
1030 memcpy(new_data->data(), data.data(), data.size()); 1029 memcpy(new_data->data(), data.data(), data.size());
1031 1030
1032 // Call write file functionality in file thread. 1031 // Call write file functionality in file thread.
1033 BrowserThread::PostTask( 1032 BrowserThread::PostTask(
1034 BrowserThread::FILE, FROM_HERE, 1033 BrowserThread::FILE, FROM_HERE,
1035 NewRunnableMethod(file_manager_, 1034 NewRunnableMethod(file_manager_,
1036 &SaveFileManager::UpdateSaveProgress, 1035 &SaveFileManager::UpdateSaveProgress,
1037 save_item->save_id(), 1036 save_item->save_id(),
1038 new_data, 1037 new_data,
1039 static_cast<int>(data.size()))); 1038 static_cast<int>(data.size())));
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 int index, void* params) { 1395 int index, void* params) {
1397 SavePackageParam* save_params = reinterpret_cast<SavePackageParam*>(params); 1396 SavePackageParam* save_params = reinterpret_cast<SavePackageParam*>(params);
1398 ContinueSave(save_params, path, index); 1397 ContinueSave(save_params, path, index);
1399 delete save_params; 1398 delete save_params;
1400 } 1399 }
1401 1400
1402 void SavePackage::FileSelectionCanceled(void* params) { 1401 void SavePackage::FileSelectionCanceled(void* params) {
1403 SavePackageParam* save_params = reinterpret_cast<SavePackageParam*>(params); 1402 SavePackageParam* save_params = reinterpret_cast<SavePackageParam*>(params);
1404 delete save_params; 1403 delete save_params;
1405 } 1404 }
OLDNEW
« no previous file with comments | « chrome/browser/download/save_file_manager.cc ('k') | chrome/browser/renderer_host/save_file_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698