Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/renderer_host/save_file_resource_handler.cc

Issue 3966007: Fix save file stuff to use scoped_refptr for refcounted params. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/download/save_package.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/save_file_resource_handler.h" 5 #include "chrome/browser/renderer_host/save_file_resource_handler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/string_number_conversions.h" 9 #include "base/string_number_conversions.h"
10 #include "chrome/browser/browser_thread.h" 10 #include "chrome/browser/browser_thread.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 *buf_size = min_size < 0 ? kReadBufSize : min_size; 73 *buf_size = min_size < 0 ? kReadBufSize : min_size;
74 read_buffer_ = new net::IOBuffer(*buf_size); 74 read_buffer_ = new net::IOBuffer(*buf_size);
75 } 75 }
76 *buf = read_buffer_.get(); 76 *buf = read_buffer_.get();
77 return true; 77 return true;
78 } 78 }
79 79
80 bool SaveFileResourceHandler::OnReadCompleted(int request_id, int* bytes_read) { 80 bool SaveFileResourceHandler::OnReadCompleted(int request_id, int* bytes_read) {
81 DCHECK(read_buffer_); 81 DCHECK(read_buffer_);
82 // We are passing ownership of this buffer to the save file manager. 82 // We are passing ownership of this buffer to the save file manager.
83 net::IOBuffer* buffer = NULL; 83 scoped_refptr<net::IOBuffer> buffer;
84 read_buffer_.swap(&buffer); 84 read_buffer_.swap(buffer);
85 BrowserThread::PostTask( 85 BrowserThread::PostTask(
86 BrowserThread::FILE, FROM_HERE, 86 BrowserThread::FILE, FROM_HERE,
87 NewRunnableMethod(save_manager_, 87 NewRunnableMethod(save_manager_,
88 &SaveFileManager::UpdateSaveProgress, 88 &SaveFileManager::UpdateSaveProgress,
89 save_id_, 89 save_id_,
90 buffer, 90 buffer,
91 *bytes_read)); 91 *bytes_read));
92 return true; 92 return true;
93 } 93 }
94 94
(...skipping 15 matching lines...) Expand all
110 110
111 void SaveFileResourceHandler::OnRequestClosed() { 111 void SaveFileResourceHandler::OnRequestClosed() {
112 } 112 }
113 113
114 void SaveFileResourceHandler::set_content_length( 114 void SaveFileResourceHandler::set_content_length(
115 const std::string& content_length) { 115 const std::string& content_length) {
116 base::StringToInt64(content_length, &content_length_); 116 base::StringToInt64(content_length, &content_length_);
117 } 117 }
118 118
119 SaveFileResourceHandler::~SaveFileResourceHandler() {} 119 SaveFileResourceHandler::~SaveFileResourceHandler() {}
OLDNEW
« no previous file with comments | « chrome/browser/download/save_package.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698