Chromium Code Reviews
Help | Chromium Project | Sign in
(7)

Issue 3966007: Fix save file stuff to use scoped_refptr for refcounted params. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by willchan no longer on Chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix save file stuff to use scoped_refptr for refcounted params. BUG=28083 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/download/save_file_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/download/save_package.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/save_file_resource_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
willchan no longer on Chromium
4 years, 8 months ago (2010-10-23 00:11:37 UTC) #1
Paweł Hajdan Jr.
Assuming there are no leaks / use-after-free issues after applying this, LGTM. I don't fully ...
4 years, 8 months ago (2010-10-25 16:52:41 UTC) #2
willchan no longer on Chromium
NewRunnableMethod() uses templating to generate the Params which is stored in the Task subtype as ...
4 years, 8 months ago (2010-10-25 17:06:48 UTC) #3
rdsmith
4 years, 8 months ago (2010-10-25 17:14:16 UTC) #4
On 2010/10/23 00:11:37, willchan wrote:
> 

LGTM.  Nice work.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d