Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 394953002: {Csv,Block}PageMeasurementResults no longer perform streaming output. (Closed)

Created:
6 years, 5 months ago by chrishenry
Modified:
6 years, 5 months ago
Reviewers:
nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

{Csv,Block}PageMeasurementResults no longer perform streaming output. As a results, kill now unused results_are_the_same_on_every_page. This unfortunately changes the behaviors in the following ways: 1) Streaming Csv/Block results output on per page run (e.g., one output per page repeat), the streaming mode merges like values for the same page (in case of page repeat, it merges results across repeat). 2) Ordering of output rows may change. BUG=346956, 392901 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285477

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebase. #

Patch Set 3 : Address review comment. #

Patch Set 4 : #

Patch Set 5 : Rebase again. #

Patch Set 6 : Rebase again (!!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -165 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/measurements/loading_profile.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/measurements/loading_trace.py View 5 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/measurements/media.py View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/perf/measurements/page_cycler.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/perf/measurements/thread_times.py View 5 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/results/block_page_measurement_results.py View 1 1 chunk +17 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/results/csv_page_measurement_results.py View 1 2 5 chunks +12 lines, -48 lines 0 comments Download
M tools/telemetry/telemetry/results/csv_page_measurement_results_unittest.py View 5 chunks +21 lines, -57 lines 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
chrishenry
6 years, 5 months ago (2014-07-18 01:46:47 UTC) #1
nduca
lgtm https://codereview.chromium.org/394953002/diff/40001/tools/telemetry/telemetry/results/csv_page_measurement_results.py File tools/telemetry/telemetry/results/csv_page_measurement_results.py (right): https://codereview.chromium.org/394953002/diff/40001/tools/telemetry/telemetry/results/csv_page_measurement_results.py#newcode43 tools/telemetry/telemetry/results/csv_page_measurement_results.py:43: representative_value = {} i'd suggest representative_values
6 years, 5 months ago (2014-07-24 00:10:18 UTC) #2
chrishenry
https://codereview.chromium.org/394953002/diff/40001/tools/telemetry/telemetry/results/csv_page_measurement_results.py File tools/telemetry/telemetry/results/csv_page_measurement_results.py (right): https://codereview.chromium.org/394953002/diff/40001/tools/telemetry/telemetry/results/csv_page_measurement_results.py#newcode43 tools/telemetry/telemetry/results/csv_page_measurement_results.py:43: representative_value = {} On 2014/07/24 00:10:18, nduca wrote: > ...
6 years, 5 months ago (2014-07-24 15:24:15 UTC) #3
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-24 16:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/394953002/100001
6 years, 5 months ago (2014-07-24 16:39:34 UTC) #5
chrishenry
The CQ bit was unchecked by chrishenry@google.com
6 years, 5 months ago (2014-07-24 17:17:11 UTC) #6
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-24 17:17:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/394953002/120001
6 years, 5 months ago (2014-07-24 17:18:41 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 20:29:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 21:02:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2044)
6 years, 5 months ago (2014-07-24 21:02:23 UTC) #11
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-24 21:19:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/394953002/120001
6 years, 5 months ago (2014-07-24 21:22:18 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 21:58:21 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:31:19 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2124)
6 years, 5 months ago (2014-07-24 22:31:20 UTC) #16
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-24 23:06:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/394953002/120001
6 years, 5 months ago (2014-07-24 23:09:16 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 23:15:28 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 23:21:11 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/51344) linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2187)
6 years, 5 months ago (2014-07-24 23:21:12 UTC) #21
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-24 23:41:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/394953002/160001
6 years, 5 months ago (2014-07-24 23:44:55 UTC) #23
chrishenry
The CQ bit was unchecked by chrishenry@google.com
6 years, 5 months ago (2014-07-25 03:35:37 UTC) #24
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 5 months ago (2014-07-25 03:35:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/394953002/160001
6 years, 5 months ago (2014-07-25 03:36:08 UTC) #26
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 04:25:04 UTC) #27
Message was sent while issue was closed.
Change committed as 285477

Powered by Google App Engine
This is Rietveld 408576698