Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: tools/telemetry/telemetry/page/page_measurement.py

Issue 394953002: {Csv,Block}PageMeasurementResults no longer perform streaming output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase again (!!) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_measurement.py
diff --git a/tools/telemetry/telemetry/page/page_measurement.py b/tools/telemetry/telemetry/page/page_measurement.py
index 72d87ea2e1f84347b88f6525509f4318ac2c5973..13e9c479db4b8a7abbf0128a06785bee4fc55a70 100644
--- a/tools/telemetry/telemetry/page/page_measurement.py
+++ b/tools/telemetry/telemetry/page/page_measurement.py
@@ -63,16 +63,6 @@ class PageMeasurement(page_test.PageTest):
finally:
results.DidMeasurePage()
- @property
- def results_are_the_same_on_every_page(self):
- """By default, measurements are assumed to output the same values for every
- page. This allows incremental output, for example in CSV. If, however, the
- measurement discovers what values it can report as it goes, and those values
- may vary from page to page, you need to override this function and return
- False. Output will not appear in this mode until the entire pageset has
- run."""
- return True
-
def MeasurePage(self, page, tab, results):
"""Override to actually measure the page's performance.
« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | tools/telemetry/telemetry/results/block_page_measurement_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698