Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py

Issue 394953002: {Csv,Block}PageMeasurementResults no longer perform streaming output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase again (!!) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
index 071c40fb6d3666b164fc2a9e95836c4a7e3f8e84..fe58e9a77dab0d0c7db4b2d88e58b2b536e32108 100644
--- a/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/results/block_page_measurement_results_unittest.py
@@ -41,7 +41,7 @@ class BlockPageMeasurementResultsTest(unittest.TestCase):
def data(self):
return [line.split(': ', 1) for line in self.lines]
- def test_with_output_after_every_page(self):
+ def testOutput(self):
results = NonPrintingBlockPageMeasurementResults(self._output)
results.WillMeasurePage(self._page_set[0])
results.AddValue(
@@ -53,12 +53,13 @@ class BlockPageMeasurementResultsTest(unittest.TestCase):
scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 4))
results.DidMeasurePage()
+ results.PrintSummary()
expected = [
['name', 'http://www.foo.com/'],
- ['foo (seconds)', '3'],
+ ['foo (seconds)', '[3]'],
[''],
['name', 'http://www.bar.com/'],
- ['bar (seconds)', '4'],
+ ['bar (seconds)', '[4]'],
['']
]
self.assertEquals(self.data, expected)

Powered by Google App Engine
This is Rietveld 408576698