tools/perf/benchmarks/blink_perf.py - Issue 394953002: {Csv,Block}PageMeasurementResults no longer perform streaming output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 394953002: {Csv,Block}PageMeasurementResults no longer perform streaming output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase again (!!) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/blink_perf.py

diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py

index 5295af01af16ce5c839e13336ac90163528b9997..975a7cf2f8e08067f6df819ce8e394354d593dda 100644

--- a/tools/perf/benchmarks/blink_perf.py

+++ b/tools/perf/benchmarks/blink_perf.py

@@ -63,10 +63,6 @@ class _BlinkPerfMeasurement(page_measurement.PageMeasurement):

'blink_perf.js'), 'r') as f:

self._blink_perf_js = f.read()

- @property

- def results_are_the_same_on_every_page(self):

- return False

def WillNavigateToPage(self, page, tab):

page.script_to_evaluate_on_commit = self._blink_perf_js

« no previous file with comments | « no previous file | tools/perf/benchmarks/dom_perf.py » ('j') | no next file with comments »