Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392623005: Revert 283003 "[ChromeDriver] Subscribe PerformanceLogger to Com..." (Closed)

Created:
6 years, 5 months ago by Ryan Sleevi
Modified:
6 years, 5 months ago
Reviewers:
johnmoore
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 283003 "[ChromeDriver] Subscribe PerformanceLogger to Com..." > [ChromeDriver] Subscribe PerformanceLogger to CommandListener interface > > BUG= > > Review URL: https://codereview.chromium.org/353063005 TBR=johnmoore@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -622 lines) Patch
M trunk/src/chrome/chrome_tests.gypi View 5 chunks +3 lines, -7 lines 0 comments Download
A + trunk/src/chrome/test/chromedriver/chrome/performance_logger.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/chromedriver/chrome/performance_logger.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/chromedriver/chrome/performance_logger_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/test/chromedriver/command_listener.h View 1 chunk +0 lines, -22 lines 0 comments Download
D trunk/src/chrome/test/chromedriver/command_listener_proxy.h View 1 chunk +0 lines, -30 lines 0 comments Download
D trunk/src/chrome/test/chromedriver/command_listener_proxy.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D trunk/src/chrome/test/chromedriver/command_listener_proxy_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/commands.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/commands_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/logging.h View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/logging.cc View 4 chunks +6 lines, -16 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/logging_unittest.cc View 3 chunks +9 lines, -19 lines 0 comments Download
D trunk/src/chrome/test/chromedriver/performance_logger.h View 1 chunk +0 lines, -43 lines 0 comments Download
D trunk/src/chrome/test/chromedriver/performance_logger.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D trunk/src/chrome/test/chromedriver/performance_logger_unittest.cc View 1 chunk +0 lines, -190 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/session.h View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/session_commands.cc View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/session_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/util.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/util.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
6 years, 5 months ago (2014-07-14 21:17:29 UTC) #1
Ryan Sleevi
6 years, 5 months ago (2014-07-14 21:17:42 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r283023.

Powered by Google App Engine
This is Rietveld 408576698