Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: trunk/src/chrome/test/chromedriver/logging_unittest.cc

Issue 392623005: Revert 283003 "[ChromeDriver] Subscribe PerformanceLogger to Com..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/test/chromedriver/logging_unittest.cc
===================================================================
--- trunk/src/chrome/test/chromedriver/logging_unittest.cc (revision 283022)
+++ trunk/src/chrome/test/chromedriver/logging_unittest.cc (working copy)
@@ -7,7 +7,6 @@
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
#include "chrome/test/chromedriver/chrome/log.h"
#include "chrome/test/chromedriver/chrome/status.h"
-#include "chrome/test/chromedriver/command_listener.h"
#include "chrome/test/chromedriver/logging.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -102,15 +101,12 @@
capabilities.logging_prefs["performance"] = Log::kInfo;
capabilities.logging_prefs["browser"] = Log::kInfo;
- ScopedVector<DevToolsEventListener> devtools_listeners;
+ ScopedVector<DevToolsEventListener> listeners;
ScopedVector<WebDriverLog> logs;
- ScopedVector<CommandListener> command_listeners;
- Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
- &command_listeners);
+ Status status = CreateLogs(capabilities, &logs, &listeners);
ASSERT_TRUE(status.IsOk());
ASSERT_EQ(2u, logs.size());
- ASSERT_EQ(2u, devtools_listeners.size());
- ASSERT_EQ(1u, command_listeners.size());
+ ASSERT_EQ(2u, listeners.size());
ASSERT_EQ("performance", logs[0]->type());
ASSERT_EQ("browser", logs[1]->type());
}
@@ -119,30 +115,24 @@
Capabilities capabilities;
capabilities.logging_prefs["gaga"] = Log::kInfo;
- ScopedVector<DevToolsEventListener> devtools_listeners;
+ ScopedVector<DevToolsEventListener> listeners;
ScopedVector<WebDriverLog> logs;
- ScopedVector<CommandListener> command_listeners;
- Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
- &command_listeners);
+ Status status = CreateLogs(capabilities, &logs, &listeners);
EXPECT_TRUE(status.IsOk());
ASSERT_EQ(1u, logs.size());
- ASSERT_EQ(1u, devtools_listeners.size());
- ASSERT_EQ(0u, command_listeners.size());
+ ASSERT_EQ(1u, listeners.size());
ASSERT_EQ("browser", logs[0]->type());
}
TEST(Logging, DefaultLogs) {
Capabilities capabilities;
- ScopedVector<DevToolsEventListener> devtools_listeners;
+ ScopedVector<DevToolsEventListener> listeners;
ScopedVector<WebDriverLog> logs;
- ScopedVector<CommandListener> command_listeners;
- Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
- &command_listeners);
+ Status status = CreateLogs(capabilities, &logs, &listeners);
EXPECT_TRUE(status.IsOk());
ASSERT_EQ(1u, logs.size());
- ASSERT_EQ(1u, devtools_listeners.size());
- ASSERT_EQ(0u, command_listeners.size());
+ ASSERT_EQ(1u, listeners.size());
ASSERT_EQ("browser", logs[0]->type());
}
« no previous file with comments | « trunk/src/chrome/test/chromedriver/logging.cc ('k') | trunk/src/chrome/test/chromedriver/performance_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698