Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: trunk/src/chrome/test/chromedriver/logging_unittest.cc

Issue 392623005: Revert 283003 "[ChromeDriver] Subscribe PerformanceLogger to Com..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/values.h" 5 #include "base/values.h"
6 #include "chrome/test/chromedriver/capabilities.h" 6 #include "chrome/test/chromedriver/capabilities.h"
7 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h" 7 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
8 #include "chrome/test/chromedriver/chrome/log.h" 8 #include "chrome/test/chromedriver/chrome/log.h"
9 #include "chrome/test/chromedriver/chrome/status.h" 9 #include "chrome/test/chromedriver/chrome/status.h"
10 #include "chrome/test/chromedriver/command_listener.h"
11 #include "chrome/test/chromedriver/logging.h" 10 #include "chrome/test/chromedriver/logging.h"
12 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
13 12
14 namespace { 13 namespace {
15 14
16 const char* const kAllWdLevels[] = { 15 const char* const kAllWdLevels[] = {
17 "ALL", "DEBUG", "INFO", "WARNING", "SEVERE", "OFF" 16 "ALL", "DEBUG", "INFO", "WARNING", "SEVERE", "OFF"
18 }; 17 };
19 18
20 } 19 }
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 ASSERT_EQ(2u, entries->GetSize()); 94 ASSERT_EQ(2u, entries->GetSize());
96 ValidateLogEntry(entries.get(), 0, "SEVERE", "severe message"); 95 ValidateLogEntry(entries.get(), 0, "SEVERE", "severe message");
97 ValidateLogEntry(entries.get(), 1, "DEBUG", "debug message"); 96 ValidateLogEntry(entries.get(), 1, "DEBUG", "debug message");
98 } 97 }
99 98
100 TEST(Logging, CreatePerformanceLog) { 99 TEST(Logging, CreatePerformanceLog) {
101 Capabilities capabilities; 100 Capabilities capabilities;
102 capabilities.logging_prefs["performance"] = Log::kInfo; 101 capabilities.logging_prefs["performance"] = Log::kInfo;
103 capabilities.logging_prefs["browser"] = Log::kInfo; 102 capabilities.logging_prefs["browser"] = Log::kInfo;
104 103
105 ScopedVector<DevToolsEventListener> devtools_listeners; 104 ScopedVector<DevToolsEventListener> listeners;
106 ScopedVector<WebDriverLog> logs; 105 ScopedVector<WebDriverLog> logs;
107 ScopedVector<CommandListener> command_listeners; 106 Status status = CreateLogs(capabilities, &logs, &listeners);
108 Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
109 &command_listeners);
110 ASSERT_TRUE(status.IsOk()); 107 ASSERT_TRUE(status.IsOk());
111 ASSERT_EQ(2u, logs.size()); 108 ASSERT_EQ(2u, logs.size());
112 ASSERT_EQ(2u, devtools_listeners.size()); 109 ASSERT_EQ(2u, listeners.size());
113 ASSERT_EQ(1u, command_listeners.size());
114 ASSERT_EQ("performance", logs[0]->type()); 110 ASSERT_EQ("performance", logs[0]->type());
115 ASSERT_EQ("browser", logs[1]->type()); 111 ASSERT_EQ("browser", logs[1]->type());
116 } 112 }
117 113
118 TEST(Logging, IgnoreUnknownLogType) { 114 TEST(Logging, IgnoreUnknownLogType) {
119 Capabilities capabilities; 115 Capabilities capabilities;
120 capabilities.logging_prefs["gaga"] = Log::kInfo; 116 capabilities.logging_prefs["gaga"] = Log::kInfo;
121 117
122 ScopedVector<DevToolsEventListener> devtools_listeners; 118 ScopedVector<DevToolsEventListener> listeners;
123 ScopedVector<WebDriverLog> logs; 119 ScopedVector<WebDriverLog> logs;
124 ScopedVector<CommandListener> command_listeners; 120 Status status = CreateLogs(capabilities, &logs, &listeners);
125 Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
126 &command_listeners);
127 EXPECT_TRUE(status.IsOk()); 121 EXPECT_TRUE(status.IsOk());
128 ASSERT_EQ(1u, logs.size()); 122 ASSERT_EQ(1u, logs.size());
129 ASSERT_EQ(1u, devtools_listeners.size()); 123 ASSERT_EQ(1u, listeners.size());
130 ASSERT_EQ(0u, command_listeners.size());
131 ASSERT_EQ("browser", logs[0]->type()); 124 ASSERT_EQ("browser", logs[0]->type());
132 } 125 }
133 126
134 TEST(Logging, DefaultLogs) { 127 TEST(Logging, DefaultLogs) {
135 Capabilities capabilities; 128 Capabilities capabilities;
136 129
137 ScopedVector<DevToolsEventListener> devtools_listeners; 130 ScopedVector<DevToolsEventListener> listeners;
138 ScopedVector<WebDriverLog> logs; 131 ScopedVector<WebDriverLog> logs;
139 ScopedVector<CommandListener> command_listeners; 132 Status status = CreateLogs(capabilities, &logs, &listeners);
140 Status status = CreateLogs(capabilities, &logs, &devtools_listeners,
141 &command_listeners);
142 EXPECT_TRUE(status.IsOk()); 133 EXPECT_TRUE(status.IsOk());
143 ASSERT_EQ(1u, logs.size()); 134 ASSERT_EQ(1u, logs.size());
144 ASSERT_EQ(1u, devtools_listeners.size()); 135 ASSERT_EQ(1u, listeners.size());
145 ASSERT_EQ(0u, command_listeners.size());
146 ASSERT_EQ("browser", logs[0]->type()); 136 ASSERT_EQ("browser", logs[0]->type());
147 } 137 }
148 138
149 TEST(Logging, GetFirstErrorMessage) { 139 TEST(Logging, GetFirstErrorMessage) {
150 WebDriverLog log(WebDriverLog::kBrowserType, Log::kAll); 140 WebDriverLog log(WebDriverLog::kBrowserType, Log::kAll);
151 std::string entry; 141 std::string entry;
152 142
153 entry = log.GetFirstErrorMessage(); 143 entry = log.GetFirstErrorMessage();
154 ASSERT_TRUE(entry.empty()); 144 ASSERT_TRUE(entry.empty());
155 145
156 log.AddEntry(Log::kInfo, "info message"); 146 log.AddEntry(Log::kInfo, "info message");
157 log.AddEntry(Log::kError, "first error message"); 147 log.AddEntry(Log::kError, "first error message");
158 log.AddEntry(Log::kDebug, "debug message"); 148 log.AddEntry(Log::kDebug, "debug message");
159 log.AddEntry(Log::kError, "second error message"); 149 log.AddEntry(Log::kError, "second error message");
160 150
161 entry = log.GetFirstErrorMessage(); 151 entry = log.GetFirstErrorMessage();
162 ASSERT_EQ("first error message", entry); 152 ASSERT_EQ("first error message", entry);
163 } 153 }
OLDNEW
« no previous file with comments | « trunk/src/chrome/test/chromedriver/logging.cc ('k') | trunk/src/chrome/test/chromedriver/performance_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698