Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: trunk/src/chrome/test/chromedriver/logging.cc

Issue 392623005: Revert 283003 "[ChromeDriver] Subscribe PerformanceLogger to Com..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/test/chromedriver/logging.cc
===================================================================
--- trunk/src/chrome/test/chromedriver/logging.cc (revision 283022)
+++ trunk/src/chrome/test/chromedriver/logging.cc (working copy)
@@ -14,9 +14,8 @@
#include "base/time/time.h"
#include "chrome/test/chromedriver/capabilities.h"
#include "chrome/test/chromedriver/chrome/console_logger.h"
+#include "chrome/test/chromedriver/chrome/performance_logger.h"
#include "chrome/test/chromedriver/chrome/status.h"
-#include "chrome/test/chromedriver/command_listener_proxy.h"
-#include "chrome/test/chromedriver/performance_logger.h"
#include "chrome/test/chromedriver/session.h"
#if defined(OS_POSIX)
@@ -240,11 +239,9 @@
Status CreateLogs(const Capabilities& capabilities,
ScopedVector<WebDriverLog>* out_logs,
- ScopedVector<DevToolsEventListener>* out_devtools_listeners,
- ScopedVector<CommandListener>* out_command_listeners) {
+ ScopedVector<DevToolsEventListener>* out_listeners) {
ScopedVector<WebDriverLog> logs;
- ScopedVector<DevToolsEventListener> devtools_listeners;
- ScopedVector<CommandListener> command_listeners;
+ ScopedVector<DevToolsEventListener> listeners;
Log::Level browser_log_level = Log::kWarning;
const LoggingPrefs& prefs = capabilities.logging_prefs;
@@ -257,13 +254,7 @@
if (level != Log::kOff) {
WebDriverLog* log = new WebDriverLog(type, Log::kAll);
logs.push_back(log);
- PerformanceLogger* perf_log = new PerformanceLogger(log);
- // We use a proxy for |perf_log|'s |CommandListener| interface.
- // session->chrome will own |perf_log|, and |session| will own |proxy|.
- // session->command_listeners (the proxy) will be destroyed first.
- CommandListenerProxy* proxy = new CommandListenerProxy(perf_log);
- devtools_listeners.push_back(perf_log);
- command_listeners.push_back(proxy);
+ listeners.push_back(new PerformanceLogger(log));
}
} else if (type == WebDriverLog::kBrowserType) {
browser_log_level = level;
@@ -280,10 +271,9 @@
logs.push_back(browser_log);
// If the level is OFF, don't even bother listening for DevTools events.
if (browser_log_level != Log::kOff)
- devtools_listeners.push_back(new ConsoleLogger(browser_log));
+ listeners.push_back(new ConsoleLogger(browser_log));
out_logs->swap(logs);
- out_devtools_listeners->swap(devtools_listeners);
- out_command_listeners->swap(command_listeners);
+ out_listeners->swap(listeners);
return Status(kOk);
}
« no previous file with comments | « trunk/src/chrome/test/chromedriver/logging.h ('k') | trunk/src/chrome/test/chromedriver/logging_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698