Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 389863002: Remove Chrome's own version of libaddressinput in favor of the upstream. (Closed)

Created:
6 years, 5 months ago by please use gerrit instead
Modified:
6 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, roubert
Project:
chromium
Visibility:
Public.

Description

Remove Chrome's own version of libaddressinput in favor of the upstream. TBR=estade@chromium.org BUG=392949 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15087 lines) Patch
D third_party/libaddressinput/chromium/cpp/LICENSE.chromium View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/README View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/grit.gyp View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/gtest.gyp View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_data.h View 1 chunk +0 lines, -92 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_field.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_formatter.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_metadata.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h View 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/callback.h View 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/downloader.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/load_rules_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/storage.h View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/basictypes.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/internal/basictypes.h View 1 chunk +0 lines, -201 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/internal/move.h View 1 chunk +0 lines, -218 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/internal/scoped_ptr.h View 1 chunk +0 lines, -597 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/internal/template_util.h View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/include/libaddressinput/util/scoped_ptr.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/libaddressinput.gyp View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/rapidjson.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/re2.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/libaddressinput_strings.grd View 1 chunk +0 lines, -191 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/libaddressinput_strings.grdp View 1 chunk +0 lines, -196 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_am.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ar.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_bg.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_bn.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ca.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_cs.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_da.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_de.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_el.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_en-GB.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_es.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_es-419.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_et.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_fa.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_fi.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_fil.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_fr.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_gu.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_hi.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_hr.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_hu.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_id.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_it.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_iw.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ja.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_kn.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ko.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_lt.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_lv.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ml.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_mr.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ms.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_nl.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_no.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_pl.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_pt-BR.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_pt-PT.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ro.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ru.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_sk.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_sl.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_sr.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_sv.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_sw.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_ta.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_te.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_th.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_tr.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_uk.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_vi.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_zh-CN.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/res/strings/libaddressinput_strings_zh-TW.xtb View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/address_data.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/address_field.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/address_formatter.cc View 1 chunk +0 lines, -190 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/address_metadata.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/address_problem.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/address_ui.cc View 1 chunk +0 lines, -256 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/address_validator.cc View 1 chunk +0 lines, -599 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/country_rules_aggregator.h View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/country_rules_aggregator.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/fallback_data_store.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/fallback_data_store.cc View 1 chunk +0 lines, -212 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/grit.h View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/language.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/language.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/region_data_constants.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/region_data_constants.cc View 1 chunk +0 lines, -1489 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/retriever.h View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/retriever.cc View 1 chunk +0 lines, -275 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/rule.h View 1 chunk +0 lines, -191 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/rule.cc View 1 chunk +0 lines, -313 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/ruleset.h View 1 chunk +0 lines, -177 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/ruleset.cc View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/canonicalize_string.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/canonicalize_string.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/cctype_tolower_equal.h View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/cctype_tolower_equal.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/json.h View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/json.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/md5.h View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/md5.cc View 1 chunk +0 lines, -299 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/stl_util.h View 1 chunk +0 lines, -227 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_util.h View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_util.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/trie.h View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/trie.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/address_data_test.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/address_formatter_test.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/address_metadata_test.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/address_ui_test.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/address_validator_test.h View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc View 1 chunk +0 lines, -592 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/country_rules_aggregator_test.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/fake_downloader.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/fake_downloader.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/fake_downloader_test.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/fake_storage.h View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/fake_storage.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/fake_storage_test.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/language_test.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/region_data_constants_test.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/retriever_test.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/rule_test.cc View 1 chunk +0 lines, -454 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/storage_test_runner.h View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/json_test.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/md5_unittest.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/scoped_ptr_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/stl_util_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/string_util_test.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/trie_test.cc View 1 chunk +0 lines, -114 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
please use gerrit instead
FYI
6 years, 5 months ago (2014-07-13 19:27:19 UTC) #1
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-13 19:27:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/389863002/1
6 years, 5 months ago (2014-07-13 19:28:10 UTC) #3
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 5 months ago (2014-07-13 19:33:56 UTC) #4
please use gerrit instead
FYI
6 years, 5 months ago (2014-07-13 19:34:27 UTC) #5
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-13 19:34:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/389863002/1
6 years, 5 months ago (2014-07-13 19:35:15 UTC) #7
commit-bot: I haz the power
Change committed as 282887
6 years, 5 months ago (2014-07-14 02:20:23 UTC) #8
Evan Stade
6 years, 5 months ago (2014-07-14 18:18:37 UTC) #9
Message was sent while issue was closed.
yay, lgtm

Powered by Google App Engine
This is Rietveld 408576698