Issue 388833003: Remove Skia's use of the default SkPicture constructor and multi-clone

Issue 388833003: Remove Skia's use of the default SkPicture constructor and multi-clone (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove Skia's use of the default SkPicture constructor and multi-clone This cannot be landed until (Chrome: Switch to one-at-a-time SkPicture::clone interface - https://codereview.chromium.org/380323002/) has landed. R=mtklein@google.com TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/cfaeec4

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -85 lines)			Patch
M	gyp/skia_for_android_framework_defines.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkPicture.h	View	1 2	3 chunks	+4 lines, -9 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	1 2	3 chunks	+47 lines, -61 lines	0 comments	Download
M	src/core/SkPictureData.h	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/core/SkPictureData.cpp	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/GpuLayerCacheTest.cpp	View		5 chunks	+9 lines, -6 lines	0 comments	Download
M	tests/PictureTest.cpp	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 7 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-07-13 15:49:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/388833003/60001

6 years, 5 months ago (2014-07-13 15:49:51 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 5 months ago (2014-07-13 15:49:56 UTC) #5

commit-bot: I haz the power

Presubmit check for 388833003-60001 failed and returned exit status 1. Running presubmit commit checks ...

6 years, 5 months ago (2014-07-13 15:49:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as rcfaeec4.