Chromium Code Reviews Chromium Code Reviews
Issue
38823002:
Web Animations CSS: Support animation of {text,box,-webkit-box}-shadow and fix blur clamping (Closed)
DescriptionWeb Animations CSS: Support animation of {text,box,-webkit-box}-shadow and fix blur clamping
This patch adds support for animating the shadow properties in the
Web Animations implementation. We fix the interpolation of blur to
clamp to zero, but leave the existing incorrect behaviour in which
shadow lists with mismatched shadows will interpolate anyway, even
though the spec suggests (it is poorly written!) that we shouldn't
be doing any interpolation here.
The code for interpolating ShadowLists in CSSPropertyAnimation has
been moved to ShadowList and ShadowData, so we can re-use it, with
minor stylistic changes.
Note that some of the test expectation failures are due to integer
rounding, which https://codereview.chromium.org/23241010/ probably
will resolve.
BUG=257591
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160421
Patch Set 1 #
Total comments: 11
Patch Set 2 : address comments #
Total comments: 6
Patch Set 3 : use 0 instead of PassRefPtr<..>() #Messages
Total messages: 9 (0 generated)
|
