Web Animations CSS: Support animation of {text,box,-webkit-box}-shadow and fix blur clamping

Source/core/animation/AnimatableShadow.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef AnimatableSVGLength_h
-#define AnimatableSVGLength_h
+#ifndef AnimatableShadow_h
+#define AnimatableShadow_h
 
 #include "core/animation/AnimatableValue.h"
-#include "core/svg/SVGLength.h"
+#include "core/rendering/style/ShadowList.h"
 
 namespace WebCore {
 
-class AnimatableSVGLength: public AnimatableValue {
+class AnimatableShadow : public AnimatableValue {
 public:
-    virtual ~AnimatableSVGLength() { }
-
-    static PassRefPtr<AnimatableSVGLength> create(const SVGLength& length)
+    virtual ~AnimatableShadow() { }
+    static PassRefPtr<AnimatableShadow> create(PassRefPtr<ShadowList> shadowList)
     {
-        return adoptRef(new AnimatableSVGLength(length));
+        return adoptRef(new AnimatableShadow(shadowList));
     }
-
-    const SVGLength& toSVGLength() const
-    {
-        return m_length;
-    }
+    ShadowList* shadowList() const { return m_shadowList.get(); }
 
 protected:
     virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*, double fraction) const OVERRIDE;
     virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue*) const OVERRIDE;
 
 private:
-    AnimatableSVGLength(const SVGLength& length)
-        : m_length(length)
+    explicit AnimatableShadow(PassRefPtr<ShadowList> shadowList)
+        : m_shadowList(shadowList)
     {
     }
-
-    virtual AnimatableType type() const { return TypeSVGLength; }
+    virtual AnimatableType type() const OVERRIDE { return TypeShadow; }
     virtual bool equalTo(const AnimatableValue*) const OVERRIDE;
 
-    SVGLength m_length;
+    const RefPtr<ShadowList> m_shadowList;

[mithro-old, 2013/10/24 01:04:16]

Why const?

[Timothy Loh, 2013/10/24 03:04:54]

It doesn't change. Probably the better question is why the getter returns a
non-const ShadowList -- this is because we need to ref the object to apply it,
and this requires it to be non-const. ShadowList objects are logically const
anyway.

 };
 
-DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableSVGLength, isSVGLength());
+DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableShadow, isShadow());
 
 } // namespace WebCore
 
-#endif // AnimatableSVGLength_h
+#endif // AnimatableShadow_h