Web Animations CSS: Support animation of {text,box,-webkit-box}-shadow and fix blur clamping

Source/core/animation/AnimatableShadow.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 11 matching lines @@
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-#include "core/animation/AnimatableSVGLength.h"
-
-#include "platform/FloatConversion.h"
+#include "core/animation/AnimatableShadow.h"
 
 namespace WebCore {
 
-PassRefPtr<AnimatableValue> AnimatableSVGLength::interpolateTo(const AnimatableValue* value, double fraction) const
+PassRefPtr<AnimatableValue> AnimatableShadow::interpolateTo(const AnimatableValue* value, double fraction) const
 {
-    return create(toAnimatableSVGLength(value)->toSVGLength().blend(m_length, narrowPrecisionToFloat(fraction)));
+    const AnimatableShadow* shadowList = toAnimatableShadow(value);
+    return AnimatableShadow::create(ShadowList::blend(m_shadowList.get(), shadowList->m_shadowList.get(), fraction));
 }
 
-PassRefPtr<AnimatableValue> AnimatableSVGLength::addWith(const AnimatableValue* value) const
+PassRefPtr<AnimatableValue> AnimatableShadow::addWith(const AnimatableValue* value) const
 {
-    RELEASE_ASSERT_WITH_MESSAGE(false, "Web Animations not yet implemented: AnimatableSVGLength::addWith()");
-    return 0;
+    // FIXME: The spec doesn't specify anything for shadow in particular, but
+    // the default behaviour is probably not what one would expect.
+    return AnimatableValue::defaultAddWith(this, value);
 }
 
-bool AnimatableSVGLength::equalTo(const AnimatableValue* value) const
+bool AnimatableShadow::equalTo(const AnimatableValue* value) const
 {
-    return m_length == toAnimatableSVGLength(value)->m_length;
+    const ShadowList* shadowList = toAnimatableShadow(value)->m_shadowList.get();

[mithro-old, 2013/10/24 01:04:16]

Where is toAnimatableShadow implemented? 

[Timothy Loh, 2013/10/24 03:04:54]

In this macro DEFINE_ANIMATABLE_VALUE_TYPE_CASTS(AnimatableShadow, isShadow()),
which replaces the previous manual definitions.

+    return m_shadowList == shadowList || (m_shadowList && shadowList && *m_shadowList == *shadowList);
 }
 
 } // namespace WebCore