Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 386283002: Move bookmark_utils into bookmarks namespace. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, tfarina, haitaol+watch_chromium.org, dcheng, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, maniscalco+watch_chromium.org, blundell, sdefresne, nshaik
Project:
chromium
Visibility:
Public.

Description

Move bookmark_utils into bookmarks namespace. BUG=370433 TEST=None R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283224

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -163 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 8 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 9 chunks +12 lines, -10 lines 1 comment Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/scored_history_match.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 9 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_drag_drop.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 10 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/undo/bookmark_undo_service.cc View 5 chunks +17 lines, -10 lines 0 comments Download
M components/bookmarks/browser/bookmark_index.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_utils.h View 3 chunks +5 lines, -7 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 5 months ago (2014-07-13 21:48:43 UTC) #1
sky
LGTM https://codereview.chromium.org/386283002/diff/20001/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc File chrome/browser/extensions/api/bookmarks/bookmarks_api.cc (right): https://codereview.chromium.org/386283002/diff/20001/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc#newcode64 chrome/browser/extensions/api/bookmarks/bookmarks_api.cc:64: namespace bookmarks = api::bookmarks; I think we should ...
6 years, 5 months ago (2014-07-14 17:05:50 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-15 00:55:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/386283002/20001
6 years, 5 months ago (2014-07-15 00:57:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-15 18:12:12 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 18:57:03 UTC) #6
Message was sent while issue was closed. 
Change committed as 283224

Powered by Google App Engine
This is Rietveld 408576698