Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 386283002: Move bookmark_utils into bookmarks namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 5 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/rand_util.h" 10 #include "base/rand_util.h"
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 const GURL& url) { 424 const GURL& url) {
425 return AddURL(profile, GetBookmarkBarNode(profile), index, title, url); 425 return AddURL(profile, GetBookmarkBarNode(profile), index, title, url);
426 } 426 }
427 427
428 const BookmarkNode* AddURL(int profile, 428 const BookmarkNode* AddURL(int profile,
429 const BookmarkNode* parent, 429 const BookmarkNode* parent,
430 int index, 430 int index,
431 const std::string& title, 431 const std::string& title,
432 const GURL& url) { 432 const GURL& url) {
433 BookmarkModel* model = GetBookmarkModel(profile); 433 BookmarkModel* model = GetBookmarkModel(profile);
434 if (GetBookmarkNodeByID(model, parent->id()) != parent) { 434 if (bookmarks::GetBookmarkNodeByID(model, parent->id()) != parent) {
435 LOG(ERROR) << "Node " << parent->GetTitle() << " does not belong to " 435 LOG(ERROR) << "Node " << parent->GetTitle() << " does not belong to "
436 << "Profile " << profile; 436 << "Profile " << profile;
437 return NULL; 437 return NULL;
438 } 438 }
439 const BookmarkNode* result = 439 const BookmarkNode* result =
440 model->AddURL(parent, index, base::UTF8ToUTF16(title), url); 440 model->AddURL(parent, index, base::UTF8ToUTF16(title), url);
441 if (!result) { 441 if (!result) {
442 LOG(ERROR) << "Could not add bookmark " << title << " to Profile " 442 LOG(ERROR) << "Could not add bookmark " << title << " to Profile "
443 << profile; 443 << profile;
444 return NULL; 444 return NULL;
(...skipping 21 matching lines...) Expand all
466 int index, 466 int index,
467 const std::string& title) { 467 const std::string& title) {
468 return AddFolder(profile, GetBookmarkBarNode(profile), index, title); 468 return AddFolder(profile, GetBookmarkBarNode(profile), index, title);
469 } 469 }
470 470
471 const BookmarkNode* AddFolder(int profile, 471 const BookmarkNode* AddFolder(int profile,
472 const BookmarkNode* parent, 472 const BookmarkNode* parent,
473 int index, 473 int index,
474 const std::string& title) { 474 const std::string& title) {
475 BookmarkModel* model = GetBookmarkModel(profile); 475 BookmarkModel* model = GetBookmarkModel(profile);
476 if (GetBookmarkNodeByID(model, parent->id()) != parent) { 476 if (bookmarks::GetBookmarkNodeByID(model, parent->id()) != parent) {
477 LOG(ERROR) << "Node " << parent->GetTitle() << " does not belong to " 477 LOG(ERROR) << "Node " << parent->GetTitle() << " does not belong to "
478 << "Profile " << profile; 478 << "Profile " << profile;
479 return NULL; 479 return NULL;
480 } 480 }
481 const BookmarkNode* result = 481 const BookmarkNode* result =
482 model->AddFolder(parent, index, base::UTF8ToUTF16(title)); 482 model->AddFolder(parent, index, base::UTF8ToUTF16(title));
483 EXPECT_TRUE(result); 483 EXPECT_TRUE(result);
484 if (!result) { 484 if (!result) {
485 LOG(ERROR) << "Could not add folder " << title << " to Profile " 485 LOG(ERROR) << "Could not add folder " << title << " to Profile "
486 << profile; 486 << profile;
(...skipping 10 matching lines...) Expand all
497 } 497 }
498 EXPECT_TRUE(NodesMatch(v_node, result)); 498 EXPECT_TRUE(NodesMatch(v_node, result));
499 } 499 }
500 return result; 500 return result;
501 } 501 }
502 502
503 void SetTitle(int profile, 503 void SetTitle(int profile,
504 const BookmarkNode* node, 504 const BookmarkNode* node,
505 const std::string& new_title) { 505 const std::string& new_title) {
506 BookmarkModel* model = GetBookmarkModel(profile); 506 BookmarkModel* model = GetBookmarkModel(profile);
507 ASSERT_EQ(GetBookmarkNodeByID(model, node->id()), node) 507 ASSERT_EQ(bookmarks::GetBookmarkNodeByID(model, node->id()), node)
508 << "Node " << node->GetTitle() << " does not belong to " 508 << "Node " << node->GetTitle() << " does not belong to "
509 << "Profile " << profile; 509 << "Profile " << profile;
510 if (sync_datatype_helper::test()->use_verifier()) { 510 if (sync_datatype_helper::test()->use_verifier()) {
511 const BookmarkNode* v_node = NULL; 511 const BookmarkNode* v_node = NULL;
512 FindNodeInVerifier(model, node, &v_node); 512 FindNodeInVerifier(model, node, &v_node);
513 GetVerifierBookmarkModel()->SetTitle(v_node, base::UTF8ToUTF16(new_title)); 513 GetVerifierBookmarkModel()->SetTitle(v_node, base::UTF8ToUTF16(new_title));
514 } 514 }
515 model->SetTitle(node, base::UTF8ToUTF16(new_title)); 515 model->SetTitle(node, base::UTF8ToUTF16(new_title));
516 } 516 }
517 517
518 void SetFavicon(int profile, 518 void SetFavicon(int profile,
519 const BookmarkNode* node, 519 const BookmarkNode* node,
520 const GURL& icon_url, 520 const GURL& icon_url,
521 const gfx::Image& image, 521 const gfx::Image& image,
522 FaviconSource favicon_source) { 522 FaviconSource favicon_source) {
523 BookmarkModel* model = GetBookmarkModel(profile); 523 BookmarkModel* model = GetBookmarkModel(profile);
524 ASSERT_EQ(GetBookmarkNodeByID(model, node->id()), node) 524 ASSERT_EQ(bookmarks::GetBookmarkNodeByID(model, node->id()), node)
525 << "Node " << node->GetTitle() << " does not belong to " 525 << "Node " << node->GetTitle() << " does not belong to "
526 << "Profile " << profile; 526 << "Profile " << profile;
527 ASSERT_EQ(BookmarkNode::URL, node->type()) << "Node " << node->GetTitle() 527 ASSERT_EQ(BookmarkNode::URL, node->type()) << "Node " << node->GetTitle()
528 << " must be a url."; 528 << " must be a url.";
529 if (urls_with_favicons_ == NULL) 529 if (urls_with_favicons_ == NULL)
530 urls_with_favicons_ = new std::set<GURL>(); 530 urls_with_favicons_ = new std::set<GURL>();
531 urls_with_favicons_->insert(node->url()); 531 urls_with_favicons_->insert(node->url());
532 if (sync_datatype_helper::test()->use_verifier()) { 532 if (sync_datatype_helper::test()->use_verifier()) {
533 const BookmarkNode* v_node = NULL; 533 const BookmarkNode* v_node = NULL;
534 FindNodeInVerifier(model, node, &v_node); 534 FindNodeInVerifier(model, node, &v_node);
535 SetFaviconImpl(sync_datatype_helper::test()->verifier(), 535 SetFaviconImpl(sync_datatype_helper::test()->verifier(),
536 v_node, 536 v_node,
537 icon_url, 537 icon_url,
538 image, 538 image,
539 favicon_source); 539 favicon_source);
540 } 540 }
541 SetFaviconImpl(sync_datatype_helper::test()->GetProfile(profile), 541 SetFaviconImpl(sync_datatype_helper::test()->GetProfile(profile),
542 node, 542 node,
543 icon_url, 543 icon_url,
544 image, 544 image,
545 favicon_source); 545 favicon_source);
546 } 546 }
547 547
548 const BookmarkNode* SetURL(int profile, 548 const BookmarkNode* SetURL(int profile,
549 const BookmarkNode* node, 549 const BookmarkNode* node,
550 const GURL& new_url) { 550 const GURL& new_url) {
551 BookmarkModel* model = GetBookmarkModel(profile); 551 BookmarkModel* model = GetBookmarkModel(profile);
552 if (GetBookmarkNodeByID(model, node->id()) != node) { 552 if (bookmarks::GetBookmarkNodeByID(model, node->id()) != node) {
553 LOG(ERROR) << "Node " << node->GetTitle() << " does not belong to " 553 LOG(ERROR) << "Node " << node->GetTitle() << " does not belong to "
554 << "Profile " << profile; 554 << "Profile " << profile;
555 return NULL; 555 return NULL;
556 } 556 }
557 if (sync_datatype_helper::test()->use_verifier()) { 557 if (sync_datatype_helper::test()->use_verifier()) {
558 const BookmarkNode* v_node = NULL; 558 const BookmarkNode* v_node = NULL;
559 FindNodeInVerifier(model, node, &v_node); 559 FindNodeInVerifier(model, node, &v_node);
560 if (v_node->is_url()) 560 if (v_node->is_url())
561 GetVerifierBookmarkModel()->SetURL(v_node, new_url); 561 GetVerifierBookmarkModel()->SetURL(v_node, new_url);
562 } 562 }
563 if (node->is_url()) 563 if (node->is_url())
564 model->SetURL(node, new_url); 564 model->SetURL(node, new_url);
565 return node; 565 return node;
566 } 566 }
567 567
568 void Move(int profile, 568 void Move(int profile,
569 const BookmarkNode* node, 569 const BookmarkNode* node,
570 const BookmarkNode* new_parent, 570 const BookmarkNode* new_parent,
571 int index) { 571 int index) {
572 BookmarkModel* model = GetBookmarkModel(profile); 572 BookmarkModel* model = GetBookmarkModel(profile);
573 ASSERT_EQ(GetBookmarkNodeByID(model, node->id()), node) 573 ASSERT_EQ(bookmarks::GetBookmarkNodeByID(model, node->id()), node)
574 << "Node " << node->GetTitle() << " does not belong to " 574 << "Node " << node->GetTitle() << " does not belong to "
575 << "Profile " << profile; 575 << "Profile " << profile;
576 if (sync_datatype_helper::test()->use_verifier()) { 576 if (sync_datatype_helper::test()->use_verifier()) {
577 const BookmarkNode* v_new_parent = NULL; 577 const BookmarkNode* v_new_parent = NULL;
578 const BookmarkNode* v_node = NULL; 578 const BookmarkNode* v_node = NULL;
579 FindNodeInVerifier(model, new_parent, &v_new_parent); 579 FindNodeInVerifier(model, new_parent, &v_new_parent);
580 FindNodeInVerifier(model, node, &v_node); 580 FindNodeInVerifier(model, node, &v_node);
581 GetVerifierBookmarkModel()->Move(v_node, v_new_parent, index); 581 GetVerifierBookmarkModel()->Move(v_node, v_new_parent, index);
582 } 582 }
583 model->Move(node, new_parent, index); 583 model->Move(node, new_parent, index);
584 } 584 }
585 585
586 void Remove(int profile, const BookmarkNode* parent, int index) { 586 void Remove(int profile, const BookmarkNode* parent, int index) {
587 BookmarkModel* model = GetBookmarkModel(profile); 587 BookmarkModel* model = GetBookmarkModel(profile);
588 ASSERT_EQ(GetBookmarkNodeByID(model, parent->id()), parent) 588 ASSERT_EQ(bookmarks::GetBookmarkNodeByID(model, parent->id()), parent)
589 << "Node " << parent->GetTitle() << " does not belong to " 589 << "Node " << parent->GetTitle() << " does not belong to "
590 << "Profile " << profile; 590 << "Profile " << profile;
591 if (sync_datatype_helper::test()->use_verifier()) { 591 if (sync_datatype_helper::test()->use_verifier()) {
592 const BookmarkNode* v_parent = NULL; 592 const BookmarkNode* v_parent = NULL;
593 FindNodeInVerifier(model, parent, &v_parent); 593 FindNodeInVerifier(model, parent, &v_parent);
594 ASSERT_TRUE(NodesMatch(parent->GetChild(index), v_parent->GetChild(index))); 594 ASSERT_TRUE(NodesMatch(parent->GetChild(index), v_parent->GetChild(index)));
595 GetVerifierBookmarkModel()->Remove(v_parent, index); 595 GetVerifierBookmarkModel()->Remove(v_parent, index);
596 } 596 }
597 model->Remove(parent, index); 597 model->Remove(parent, index);
598 } 598 }
599 599
600 void RemoveAll(int profile) { 600 void RemoveAll(int profile) {
601 if (sync_datatype_helper::test()->use_verifier()) { 601 if (sync_datatype_helper::test()->use_verifier()) {
602 const BookmarkNode* root_node = GetVerifierBookmarkModel()->root_node(); 602 const BookmarkNode* root_node = GetVerifierBookmarkModel()->root_node();
603 for (int i = 0; i < root_node->child_count(); ++i) { 603 for (int i = 0; i < root_node->child_count(); ++i) {
604 const BookmarkNode* permanent_node = root_node->GetChild(i); 604 const BookmarkNode* permanent_node = root_node->GetChild(i);
605 for (int j = permanent_node->child_count() - 1; j >= 0; --j) { 605 for (int j = permanent_node->child_count() - 1; j >= 0; --j) {
606 GetVerifierBookmarkModel()->Remove(permanent_node, j); 606 GetVerifierBookmarkModel()->Remove(permanent_node, j);
607 } 607 }
608 } 608 }
609 } 609 }
610 GetBookmarkModel(profile)->RemoveAllUserBookmarks(); 610 GetBookmarkModel(profile)->RemoveAllUserBookmarks();
611 } 611 }
612 612
613 void SortChildren(int profile, const BookmarkNode* parent) { 613 void SortChildren(int profile, const BookmarkNode* parent) {
614 BookmarkModel* model = GetBookmarkModel(profile); 614 BookmarkModel* model = GetBookmarkModel(profile);
615 ASSERT_EQ(GetBookmarkNodeByID(model, parent->id()), parent) 615 ASSERT_EQ(bookmarks::GetBookmarkNodeByID(model, parent->id()), parent)
616 << "Node " << parent->GetTitle() << " does not belong to " 616 << "Node " << parent->GetTitle() << " does not belong to "
617 << "Profile " << profile; 617 << "Profile " << profile;
618 if (sync_datatype_helper::test()->use_verifier()) { 618 if (sync_datatype_helper::test()->use_verifier()) {
619 const BookmarkNode* v_parent = NULL; 619 const BookmarkNode* v_parent = NULL;
620 FindNodeInVerifier(model, parent, &v_parent); 620 FindNodeInVerifier(model, parent, &v_parent);
621 GetVerifierBookmarkModel()->SortChildren(v_parent); 621 GetVerifierBookmarkModel()->SortChildren(v_parent);
622 } 622 }
623 model->SortChildren(parent); 623 model->SortChildren(parent);
624 } 624 }
625 625
626 void ReverseChildOrder(int profile, const BookmarkNode* parent) { 626 void ReverseChildOrder(int profile, const BookmarkNode* parent) {
627 ASSERT_EQ(GetBookmarkNodeByID(GetBookmarkModel(profile), parent->id()), 627 ASSERT_EQ(
628 parent) 628 bookmarks::GetBookmarkNodeByID(GetBookmarkModel(profile), parent->id()),
629 parent)
629 << "Node " << parent->GetTitle() << " does not belong to " 630 << "Node " << parent->GetTitle() << " does not belong to "
630 << "Profile " << profile; 631 << "Profile " << profile;
631 int child_count = parent->child_count(); 632 int child_count = parent->child_count();
632 if (child_count <= 0) 633 if (child_count <= 0)
633 return; 634 return;
634 for (int index = 0; index < child_count; ++index) { 635 for (int index = 0; index < child_count; ++index) {
635 Move(profile, parent->GetChild(index), parent, child_count - index); 636 Move(profile, parent->GetChild(index), parent, child_count - index);
636 } 637 }
637 } 638 }
638 639
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 813
813 std::string IndexedSubfolderName(int i) { 814 std::string IndexedSubfolderName(int i) {
814 return base::StringPrintf("Subfolder Name %d", i); 815 return base::StringPrintf("Subfolder Name %d", i);
815 } 816 }
816 817
817 std::string IndexedSubsubfolderName(int i) { 818 std::string IndexedSubsubfolderName(int i) {
818 return base::StringPrintf("Subsubfolder Name %d", i); 819 return base::StringPrintf("Subsubfolder Name %d", i);
819 } 820 }
820 821
821 } // namespace bookmarks_helper 822 } // namespace bookmarks_helper
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698