chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 386283002: Move bookmark_utils into bookmarks namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 386283002: Move bookmark_utils into bookmarks namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/bookmarks/bookmarks_api.cc ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/view_id_util_browsertest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index e6efca5f811ca866f83b093a597a69e1e793d7b4..7683d717d496b7e99d056319c58c43364272fd77 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -80,7 +80,8 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

// Return the a BookmarkNode that has the given id (called

// "identifier" here to avoid conflict with objc's concept of "id").

- (const BookmarkNode*)nodeForIdentifier:(int)identifier {

- return GetBookmarkNodeByID(bridge_->GetBookmarkModel(), identifier);

+ return bookmarks::GetBookmarkNodeByID(bridge_->GetBookmarkModel(),

+ identifier);

}

// Open the URL of the given BookmarkNode in the current tab.