Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3859003: FBTF: Even more ctor/virtual deinlining. (Closed)

Created:
10 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), cbentzel+watch_chromium.org, fbarchard, Alpha Left Google, idana, ben+cc_chromium.org, Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, ncarter (slow), Aaron Boodman, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, scherkus (not reviewing), James Hawkins, tim (not reviewing), dhollowa
Visibility:
Public.

Description

FBTF: Even more ctor/virtual deinlining. (Only 424k off Linux debug .a files). BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63059

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -194 lines) Patch
M chrome/browser/autofill/autofill_download.h View 1 chunk +2 lines, -4 lines 1 comment Download
M chrome/browser/autofill/autofill_download.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/autofill/contact_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/contact_info.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/form_group.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autofill/form_group.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/autofill/phone_number.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/phone_number.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/blocked_content_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/blocked_content_container.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/bookmarks/recently_used_folders_combo_model.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data_appcache_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_appcache_helper.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_screenshot_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_screenshot_source.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/ntp_resource_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/ntp_resource_cache.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/core_options_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/core_options_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/options/options_managed_banner_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/options_managed_banner_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/options_ui.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/options/options_ui.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/download/drag_download_util.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/download/drag_download_util.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_dom_ui.h View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_dom_ui.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_history_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_history_api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_updater.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/file_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/file_reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/pack_extension_job.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/extension_installed_bubble_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_installed_bubble_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 1 chunk +1 line, -12 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/history/page_usage_data.h View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/history/page_usage_data.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/history/text_database.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/history/text_database.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/host_content_settings_map.h View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/host_content_settings_map.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/memory_details.h View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/memory_details.cc View 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/net/url_info.h View 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/browser/net/url_info.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/net/url_request_mock_net_error_job.h View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/net/url_request_mock_net_error_job.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/policy/managed_prefs_banner_base.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/policy/managed_prefs_banner_base.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_set_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_set_observer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/mock_render_process_host.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/mock_render_process_host.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/mock_printer.h View 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/renderer/mock_printer.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/job_status_updater.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/service/cloud_print/job_status_updater.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/service/net/service_url_request_context.h View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/service/net/service_url_request_context.cc View 3 chunks +19 lines, -5 lines 0 comments Download
M chrome/test/automation/automation_handle_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_handle_tracker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/automation/javascript_execution_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/javascript_execution_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/chrome_process_util.h View 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/test/chrome_process_util.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M media/base/callback.h View 1 chunk +1 line, -5 lines 0 comments Download
M media/base/callback.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/pts_heap.h View 1 chunk +4 lines, -3 lines 0 comments Download
A media/base/pts_heap.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 6 chunks +14 lines, -11 lines 0 comments Download
M net/socket/socket_test_util.cc View 6 chunks +37 lines, -0 lines 0 comments Download
M net/url_request/url_request_filter.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/url_request/url_request_filter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_path_manager.h View 2 chunks +7 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_path_manager.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_path_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
10 years, 2 months ago (2010-10-19 01:25:32 UTC) #1
James Hawkins
LGTM
10 years, 2 months ago (2010-10-19 01:36:14 UTC) #2
Lei Zhang
10 years, 2 months ago (2010-10-19 01:37:09 UTC) #3 
http://codereview.chromium.org/3859003/diff/1/3
File chrome/browser/autofill/autofill_download.h (right):

http://codereview.chromium.org/3859003/diff/1/3#newcode10
chrome/browser/autofill/autofill_download.h:10: #include <vector>
I think you can remove vector here.

I wish cpp lint can also say "hey, I noticed you're not using std::vector in
this file."

Powered by Google App Engine
This is Rietveld 408576698