FBTF: Even more ctor/virtual deinlining.

chrome/browser/autofill/autofill_download.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #pragma once
 
 #include <map>
 #include <vector>

[Lei Zhang, 2010/10/19 01:37:10]

I think you can remove vector here.

I wish cpp lint can also say "hey, I noticed you're not using std::vector in
this file."

 #include <string>
 
 #include "base/scoped_vector.h"
 #include "base/time.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/common/net/url_fetcher.h"
 
 class Profile;
@@ skipping 64 matching lines @@
   double GetNegativeUploadRate() const;
   // These functions called very rarely outside of theunit-tests. With current
   // percentages, they would be called once per 100 auto-fillable forms filled
   // and submitted by user. The order of magnitude would remain similar in the
   // future.
   void SetPositiveUploadRate(double rate);
   void SetNegativeUploadRate(double rate);
 
  private:
   friend class AutoFillDownloadTestHelper;  // unit-test.
-  struct FormRequestData {
-    std::vector<std::string> form_signatures;
-    AutoFillRequestType request_type;
-  };
+
+  struct FormRequestData;
 
   // Initiates request to AutoFill servers to download/upload heuristics.
   // |form_xml| - form structure XML to upload/download.
   // |request_data| - form signature hash(es) and indicator if it was a query.
   // |request_data.query| - if true the data is queried and observer notified
   //   with new data, if available. If false heuristic data is uploaded to our
   //   servers.
   bool StartRequest(const std::string& form_xml,
                     const FormRequestData& request_data);
 
@@ skipping 25 matching lines @@
   double positive_upload_rate_;
   double negative_upload_rate_;
 
   // Needed for unit-test.
   int fetcher_id_for_unittest_;
   bool is_testing_;
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_