Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/autofill/form_group.h

Issue 3859003: FBTF: Even more ctor/virtual deinlining. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/form_group.h
diff --git a/chrome/browser/autofill/form_group.h b/chrome/browser/autofill/form_group.h
index 4a61c1a4ea232039dbf5f47c7d6ed5ab7d599bd4..68a7d3abad9a91fd72c329b71244a9d86772cf6f 100644
--- a/chrome/browser/autofill/form_group.h
+++ b/chrome/browser/autofill/form_group.h
@@ -38,9 +38,7 @@ class FormGroup {
virtual string16 GetFieldText(const AutoFillType& type) const = 0;
// Returns the text for preview.
- virtual string16 GetPreviewText(const AutoFillType& type) const {
- return GetFieldText(type);
- }
+ virtual string16 GetPreviewText(const AutoFillType& type) const;
// Used to determine if the text being typed into a field matches the
// information in this FormGroup object. This is used by the preview
@@ -55,7 +53,7 @@ class FormGroup {
// Returns the label for this FormGroup item. This should be overridden for
// form group items that implement a label.
- virtual const string16& Label() const { return EmptyString16(); }
+ virtual const string16& Label() const;
// Returns true if the field data in |form_group| does not match the field
// data in this FormGroup.

Powered by Google App Engine
This is Rietveld 408576698