chrome/browser/extensions/file_reader.cc - Issue 3859003: FBTF: Even more ctor/virtual deinlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/file_reader.cc

Issue 3859003: FBTF: Even more ctor/virtual deinlining. (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/file_reader.cc

diff --git a/chrome/browser/extensions/file_reader.cc b/chrome/browser/extensions/file_reader.cc

index 485565f08c82eb4a2d47acfa650aa89916d282ff..b46e1d171c09d9bfa19c3ea98ae52d57699d6105 100644

--- a/chrome/browser/extensions/file_reader.cc

+++ b/chrome/browser/extensions/file_reader.cc

@@ -22,6 +22,8 @@ void FileReader::Start() {

NewRunnableMethod(this, &FileReader::ReadFileOnBackgroundThread));

}

+FileReader::~FileReader() {}

void FileReader::ReadFileOnBackgroundThread() {

std::string data;

bool success = file_util::ReadFileToString(resource_.GetFilePath(), &data);