Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 383653002: Revert of [ServiceWorker] Make Response class better conformance with the spec. (Closed)

Created:
6 years, 5 months ago by Yuta Kitamura
Modified:
6 years, 5 months ago
Reviewers:
falken, haraken, tkent, horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [ServiceWorker] Make Response class better conformance with the spec. (https://codereview.chromium.org/373613004/) Reason for revert: Broke content_browsertests http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/37860 ServiceWorkerVersionBrowserTest.FetchEvent_Response ServiceWorkerBrowserTest.Reload Original issue's description: > [ServiceWorker] Make Response class better conformance with the spec. > > In current implementation Response class only supports status, statusText, and headers attributes. > This change introduce type, url attributes and change the class of headers attribute from HeaderMap to Headers and make all attributes readonly. > And also this change implements the logic which is defined in the spec. > > http://fetch.spec.whatwg.org/#response-class > http://fetch.spec.whatwg.org/#response > > > This cl depends on http://crrev.com/329853012 and http://crrev.com/370733002 > > BUG=373120 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177793 TBR=falken@chromium.org,haraken@chromium.org,tkent@chromium.org,horo@chromium.org NOTREECHECKS=true NOTRY=true BUG=373120 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -472 lines) Patch
A LayoutTests/http/tests/serviceworker/headermap.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/headermap-worker.js View 1 chunk +98 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/response-worker.js View 1 chunk +21 lines, -127 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchManager.cpp View 2 chunks +1 line, -3 lines 0 comments Download
D Source/modules/serviceworkers/FetchResponseData.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/modules/serviceworkers/FetchResponseData.cpp View 1 chunk +0 lines, -107 lines 0 comments Download
A Source/modules/serviceworkers/HeaderMap.h View 1 chunk +47 lines, -0 lines 0 comments Download
A Source/modules/serviceworkers/HeaderMap.cpp View 1 chunk +93 lines, -0 lines 0 comments Download
A Source/modules/serviceworkers/HeaderMap.idl View 1 chunk +28 lines, -0 lines 0 comments Download
A Source/modules/serviceworkers/HeaderMapForEachCallback.h View 1 chunk +23 lines, -0 lines 0 comments Download
A Source/modules/serviceworkers/HeaderMapForEachCallback.idl View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Response.h View 2 chunks +16 lines, -19 lines 0 comments Download
M Source/modules/serviceworkers/Response.cpp View 1 chunk +22 lines, -128 lines 0 comments Download
M Source/modules/serviceworkers/Response.idl View 1 chunk +10 lines, -14 lines 0 comments Download
M Source/modules/serviceworkers/ResponseInit.h View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yuta Kitamura
Created Revert of [ServiceWorker] Make Response class better conformance with the spec.
6 years, 5 months ago (2014-07-10 05:12:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yutak@chromium.org/383653002/1
6 years, 5 months ago (2014-07-10 05:13:07 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 05:13:53 UTC) #3
Message was sent while issue was closed.
Change committed as 177803

Powered by Google App Engine
This is Rietveld 408576698