Source/modules/serviceworkers/FetchManager.cpp - Issue 383653002: Revert of [ServiceWorker] Make Response class better conformance with the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/FetchManager.cpp

Issue 383653002: Revert of [ServiceWorker] Make Response class better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/FetchManager.cpp

diff --git a/Source/modules/serviceworkers/FetchManager.cpp b/Source/modules/serviceworkers/FetchManager.cpp

index 430b6e8cf4f28e7e0bb107f0e97a7f1638a980c7..13e416c26af123d8ed16bbe52b637ee4b7304fb5 100644

--- a/Source/modules/serviceworkers/FetchManager.cpp

+++ b/Source/modules/serviceworkers/FetchManager.cpp

@@ -5,7 +5,6 @@

#include "config.h"

#include "FetchManager.h"

-#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScriptPromiseResolver.h"

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/V8ThrowException.h"

@@ -86,8 +85,7 @@

// FIXME: fill options.

RefPtrWillBeRawPtr<Blob> blob = Blob::create(BlobDataHandle::create(blobData.release(), m_downloadedBlobLength));

// FIXME: Handle response status correctly.

- NonThrowableExceptionState exceptionState;

- m_resolver->resolve(Response::create(blob.get(), responseInit, exceptionState));

+ m_resolver->resolve(Response::create(blob.get(), responseInit));

notifyFinished();

}

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/serviceworkers/FetchResponseData.h » ('j') | no next file with comments »