Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/bindings/core/v8/Dictionary.h

Issue 383653002: Revert of [ServiceWorker] Make Response class better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/response-worker.js ('k') | Source/bindings/core/v8/Dictionary.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 #include <v8.h> 42 #include <v8.h>
43 43
44 namespace WebCore { 44 namespace WebCore {
45 45
46 class ArrayValue; 46 class ArrayValue;
47 class DOMError; 47 class DOMError;
48 class Element; 48 class Element;
49 class LocalDOMWindow; 49 class LocalDOMWindow;
50 class Gamepad; 50 class Gamepad;
51 class MediaStream; 51 class MediaStream;
52 class HeaderMap;
52 class Headers; 53 class Headers;
53 class IDBKeyRange; 54 class IDBKeyRange;
54 class MIDIPort; 55 class MIDIPort;
55 class MediaKeyError; 56 class MediaKeyError;
56 class Notification; 57 class Notification;
57 class Path2D; 58 class Path2D;
58 class SpeechRecognitionResult; 59 class SpeechRecognitionResult;
59 class SpeechRecognitionResultList; 60 class SpeechRecognitionResultList;
60 class Storage; 61 class Storage;
61 class TrackBase; 62 class TrackBase;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 bool get(const String&, Member<SpeechRecognitionResultList>&) const; 103 bool get(const String&, Member<SpeechRecognitionResultList>&) const;
103 bool get(const String&, Member<Gamepad>&) const; 104 bool get(const String&, Member<Gamepad>&) const;
104 bool get(const String&, Member<MediaStream>&) const; 105 bool get(const String&, Member<MediaStream>&) const;
105 bool get(const String&, RefPtrWillBeMember<EventTarget>&) const; 106 bool get(const String&, RefPtrWillBeMember<EventTarget>&) const;
106 bool get(const String&, HashSet<AtomicString>&) const; 107 bool get(const String&, HashSet<AtomicString>&) const;
107 bool get(const String&, Dictionary&) const; 108 bool get(const String&, Dictionary&) const;
108 bool get(const String&, Vector<String>&) const; 109 bool get(const String&, Vector<String>&) const;
109 bool get(const String&, ArrayValue&) const; 110 bool get(const String&, ArrayValue&) const;
110 bool get(const String&, RefPtrWillBeMember<DOMError>&) const; 111 bool get(const String&, RefPtrWillBeMember<DOMError>&) const;
111 bool get(const String&, v8::Local<v8::Value>&) const; 112 bool get(const String&, v8::Local<v8::Value>&) const;
113 bool get(const String&, RefPtr<HeaderMap>&) const;
112 bool get(const String&, RefPtr<Headers>&) const; 114 bool get(const String&, RefPtr<Headers>&) const;
113 115
114 // Sets properties using default attributes. 116 // Sets properties using default attributes.
115 bool set(const String&, const v8::Handle<v8::Value>&); 117 bool set(const String&, const v8::Handle<v8::Value>&);
116 bool set(const String&, const String&); 118 bool set(const String&, const String&);
117 bool set(const String&, unsigned); 119 bool set(const String&, unsigned);
118 bool set(const String&, const Dictionary&); 120 bool set(const String&, const Dictionary&);
119 121
120 v8::Handle<v8::Value> v8Value() const { return m_options; } 122 v8::Handle<v8::Value> v8Value() const { return m_options; }
121 123
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value)) 359 if (context.isNullable() && WebCore::isUndefinedOrNull(v8Value))
358 return true; 360 return true;
359 361
360 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type.")); 362 context.throwTypeError(ExceptionMessages::incorrectPropertyType(key, "does n ot have a " + context.typeName() + " type."));
361 return false; 363 return false;
362 } 364 }
363 365
364 } 366 }
365 367
366 #endif // Dictionary_h 368 #endif // Dictionary_h
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/response-worker.js ('k') | Source/bindings/core/v8/Dictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698