Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383263005: Remove more CreateIntegerValue calls. (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove more CreateIntegerValue calls. BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283554

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : fix win compile #

Total comments: 2

Patch Set 4 : s/SetBoolean/SetInteger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -217 lines) Patch
M components/policy/core/browser/configuration_policy_handler_unittest.cc View 1 9 chunks +188 lines, -80 lines 0 comments Download
M components/policy/core/browser/configuration_policy_pref_store_unittest.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_manager_unittest.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M components/policy/core/common/mac_util.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/policy/core/common/policy_bundle_unittest.cc View 1 6 chunks +49 lines, -22 lines 0 comments Download
M components/policy/core/common/policy_service_impl_unittest.cc View 1 12 chunks +119 lines, -49 lines 0 comments Download
M components/policy/core/common/preg_parser_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/registry_dict_win.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M components/policy/core/common/schema_map_unittest.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download
M components/policy/tools/generate_policy_source.py View 1 chunk +1 line, -1 line 0 comments Download
M components/pref_registry/pref_registry_syncable.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M components/search_engines/default_search_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_prepopulate_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/url_matcher/url_matcher_factory_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_ui.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/test/additional_properties_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/arrays_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M tools/json_schema_compiler/test/callbacks_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/choices_unittest.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M tools/json_schema_compiler/test/crossref_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/functions_on_types_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/idl_schemas_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M tools/json_schema_compiler/test/objects_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/simple_api_unittest.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Evan Stade
aboxhall: content/browser/accessibility/accessibility_ui.cc blundell: components/* calamity: tools/*
6 years, 5 months ago (2014-07-11 23:05:13 UTC) #1
calamity
lgtm
6 years, 5 months ago (2014-07-14 01:28:17 UTC) #2
dmazzoni
https://codereview.chromium.org/383263005/diff/40001/content/browser/accessibility/accessibility_ui.cc File content/browser/accessibility/accessibility_ui.cc (right): https://codereview.chromium.org/383263005/diff/40001/content/browser/accessibility/accessibility_ui.cc#newcode119 content/browser/accessibility/accessibility_ui.cc:119: data->SetBoolean( This isn't a boolean, it's a bitmask stored ...
6 years, 5 months ago (2014-07-14 21:22:01 UTC) #3
Evan Stade
https://codereview.chromium.org/383263005/diff/40001/content/browser/accessibility/accessibility_ui.cc File content/browser/accessibility/accessibility_ui.cc (right): https://codereview.chromium.org/383263005/diff/40001/content/browser/accessibility/accessibility_ui.cc#newcode119 content/browser/accessibility/accessibility_ui.cc:119: data->SetBoolean( On 2014/07/14 21:22:01, dmazzoni wrote: > This isn't ...
6 years, 5 months ago (2014-07-14 21:56:31 UTC) #4
dmazzoni
lgtm for c/b/accessibility
6 years, 5 months ago (2014-07-14 22:00:01 UTC) #5
blundell
//components lgtm
6 years, 5 months ago (2014-07-15 06:55:17 UTC) #6
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-15 18:29:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/383263005/60001
6 years, 5 months ago (2014-07-15 18:33:06 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 00:20:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 00:52:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170676)
6 years, 5 months ago (2014-07-16 00:52:50 UTC) #11
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-16 22:34:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/383263005/60001
6 years, 5 months ago (2014-07-16 22:40:24 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 22:43:53 UTC) #14
Message was sent while issue was closed. 
Change committed as 283554

Powered by Google App Engine
This is Rietveld 408576698