Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/json_schema_compiler/test/choices_unittest.cc

Issue 383263005: Remove more CreateIntegerValue calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/SetBoolean/SetInteger Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/choices_unittest.cc
diff --git a/tools/json_schema_compiler/test/choices_unittest.cc b/tools/json_schema_compiler/test/choices_unittest.cc
index 5be117c35bbffc45bbe72e65828b68b6a5859307..159f10fb5fe6211be160bde56d242e96313588f5 100644
--- a/tools/json_schema_compiler/test/choices_unittest.cc
+++ b/tools/json_schema_compiler/test/choices_unittest.cc
@@ -23,17 +23,17 @@ TEST(JsonSchemaCompilerChoicesTest, TakesIntegersParamsCreate) {
EXPECT_FALSE(params);
}
{
- scoped_ptr<TakesIntegers::Params> params(TakesIntegers::Params::Create(
- *List(base::Value::CreateIntegerValue(6))));
+ scoped_ptr<TakesIntegers::Params> params(
+ TakesIntegers::Params::Create(*List(new base::FundamentalValue(6))));
ASSERT_TRUE(params);
EXPECT_FALSE(params->nums.as_integers);
EXPECT_EQ(6, *params->nums.as_integer);
}
{
scoped_ptr<TakesIntegers::Params> params(TakesIntegers::Params::Create(
- *List(List(base::Value::CreateIntegerValue(2),
- base::Value::CreateIntegerValue(6),
- base::Value::CreateIntegerValue(8)).release())));
+ *List(List(new base::FundamentalValue(2),
+ new base::FundamentalValue(6),
+ new base::FundamentalValue(8)).release())));
ASSERT_TRUE(params);
ASSERT_TRUE(params->nums.as_integers);
EXPECT_EQ(Vector(2, 6, 8), *params->nums.as_integers);
@@ -71,7 +71,7 @@ TEST(JsonSchemaCompilerChoicesTest, ObjectWithChoicesParamsCreateFail) {
{
scoped_ptr<base::DictionaryValue> object_param(new base::DictionaryValue());
object_param->SetWithoutPathExpansion("strings",
- base::Value::CreateIntegerValue(5));
+ new base::FundamentalValue(5));
scoped_ptr<base::ListValue> params_value(new base::ListValue());
params_value->Append(object_param.release());
scoped_ptr<ObjectWithChoices::Params> params(
@@ -93,7 +93,7 @@ TEST(JsonSchemaCompilerChoicesTest, ObjectWithChoicesParamsCreateFail) {
{
scoped_ptr<base::DictionaryValue> object_param(new base::DictionaryValue());
object_param->SetWithoutPathExpansion("integers",
- base::Value::CreateIntegerValue(6));
+ new base::FundamentalValue(6));
scoped_ptr<base::ListValue> params_value(new base::ListValue());
params_value->Append(object_param.release());
scoped_ptr<ObjectWithChoices::Params> params(
« no previous file with comments | « tools/json_schema_compiler/test/callbacks_unittest.cc ('k') | tools/json_schema_compiler/test/crossref_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698