components/url_matcher/url_matcher_factory_unittest.cc - Issue 383263005: Remove more CreateIntegerValue calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_matcher/url_matcher_factory_unittest.cc

Issue 383263005: Remove more CreateIntegerValue calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: s/SetBoolean/SetInteger Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/url_matcher/url_matcher_factory_unittest.cc

diff --git a/components/url_matcher/url_matcher_factory_unittest.cc b/components/url_matcher/url_matcher_factory_unittest.cc

index 697432ece0002dfa9583338070bdcf0f754b7bd1..f789a3d078ea6d1519cbfa1104adcf3f99a4a0dd 100644

--- a/components/url_matcher/url_matcher_factory_unittest.cc

+++ b/components/url_matcher/url_matcher_factory_unittest.cc

@@ -48,10 +48,10 @@ TEST(URLMatcherFactoryTest, CreateFromURLFilterDictionary) {

// Port range: Allow 80;1000-1010.

base::ListValue* port_range = new base::ListValue();

- port_range->Append(base::Value::CreateIntegerValue(1000));

- port_range->Append(base::Value::CreateIntegerValue(1010));

+ port_range->Append(new base::FundamentalValue(1000));

+ port_range->Append(new base::FundamentalValue(1010));

base::ListValue* port_ranges = new base::ListValue();

- port_ranges->Append(base::Value::CreateIntegerValue(80));

+ port_ranges->Append(new base::FundamentalValue(80));

port_ranges->Append(port_range);

base::ListValue* scheme_list = new base::ListValue();