components/autofill/core/browser/credit_card.h - Issue 382243002: Cleanup return values in autofill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card.h

Issue 382243002: Cleanup return values in autofill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/credit_card.h

diff --git a/components/autofill/core/browser/credit_card.h b/components/autofill/core/browser/credit_card.h

index 3c4c1f65c314442636df8ee31834ad0a763bd2bd..0ca1c877b909de113154907caae3c74b51d2faa9 100644

--- a/components/autofill/core/browser/credit_card.h

+++ b/components/autofill/core/browser/credit_card.h

@@ -60,7 +60,7 @@ class CreditCard : public AutofillDataModel {

const std::string& app_locale) OVERRIDE;

// Credit card preview summary, for example: ******1234, Exp: 01/2020

- const base::string16 Label() const;

+ const base::string16& Label() const;

vabr (Chromium) 2014/07/11 19:27:49 So I guess the argument with ToString() applies he

lucinka.brozkova 2014/07/11 21:05:57 Done.

// Special method to set value for HTML5 month input type.

void SetInfoForMonthInputType(const base::string16& value);