Cleanup return values in autofill

components/autofill/core/browser/autofill_profile.cc

Index: components/autofill/core/browser/autofill_profile.cc
diff --git a/components/autofill/core/browser/autofill_profile.cc b/components/autofill/core/browser/autofill_profile.cc
index e727ae47a34de9e8ed99c563ea0e18027d8afca9..7cdd168450770af62ed188c893947153b850c87b 100644
--- a/components/autofill/core/browser/autofill_profile.cc
+++ b/components/autofill/core/browser/autofill_profile.cc
@@ -481,7 +481,7 @@ bool AutofillProfile::operator!=(const AutofillProfile& profile) const {
   return !operator==(profile);
 }
 
-const base::string16 AutofillProfile::PrimaryValue() const {
+const base::string16& AutofillProfile::PrimaryValue() const {

[vabr (Chromium), 2014/07/11 13:37:43]

Here again, the returned object is local and goes out of scope after the return.
Please return by non-const value instead.

[vabr (Chromium), 2014/07/11 19:27:49]

And retracting my comment here as well, please revert the change instead, for
the same reason as ToString().

[lucinka.brozkova, 2014/07/11 21:05:57]

Done.

   return GetRawInfo(ADDRESS_HOME_LINE1) + GetRawInfo(ADDRESS_HOME_CITY);
 }