Cleanup return values in autofill

components/autofill/core/browser/credit_card.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_
 
 #include <iosfwd>
 #include <string>
 #include <vector>
@@ skipping 42 matching lines @@
   virtual base::string16 GetRawInfo(ServerFieldType type) const OVERRIDE;
   virtual void SetRawInfo(ServerFieldType type,
                           const base::string16& value) OVERRIDE;
   virtual base::string16 GetInfo(const AutofillType& type,
                                  const std::string& app_locale) const OVERRIDE;
   virtual bool SetInfo(const AutofillType& type,
                        const base::string16& value,
                        const std::string& app_locale) OVERRIDE;
 
   // Credit card preview summary, for example: ******1234, Exp: 01/2020
-  const base::string16 Label() const;
+  const base::string16& Label() const;

[vabr (Chromium), 2014/07/11 19:27:49]

So I guess the argument with ToString() applies here as well, let's revert
changes to this file (and its .cc) as well.

[lucinka.brozkova, 2014/07/11 21:05:57]

Done.

 
   // Special method to set value for HTML5 month input type.
   void SetInfoForMonthInputType(const base::string16& value);
 
   // The number altered for display, for example: ******1234
   base::string16 ObfuscatedNumber() const;
   // The last four digits of the credit card number.
   base::string16 LastFourDigits() const;
   // The user-visible type of the card, e.g. 'Mastercard'.
   base::string16 TypeForDisplay() const;
@@ skipping 85 matching lines @@
 extern const char* const kDiscoverCard;
 extern const char* const kGenericCard;
 extern const char* const kJCBCard;
 extern const char* const kMasterCard;
 extern const char* const kUnionPay;
 extern const char* const kVisaCard;
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_CREDIT_CARD_H_