components/autofill/core/browser/credit_card.cc - Issue 382243002: Cleanup return values in autofill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card.cc

Issue 382243002: Cleanup return values in autofill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/credit_card.cc

diff --git a/components/autofill/core/browser/credit_card.cc b/components/autofill/core/browser/credit_card.cc

index 25a2329b72486b539b61c09ff3c90643bb6b40ba..d38cf7b31d3fe0c9d3af9d5491da7890d8b976b4 100644

--- a/components/autofill/core/browser/credit_card.cc

+++ b/components/autofill/core/browser/credit_card.cc

@@ -411,7 +411,7 @@ void CreditCard::GetMatchingTypes(const base::string16& text,

}

-const base::string16 CreditCard::Label() const {

+const base::string16& CreditCard::Label() const {

base::string16 label;

if (number().empty())

return name_on_card_; // No CC number, return name only.