Cleanup return values in autofill

components/autofill/content/renderer/form_autofill_util.cc

Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index c2deecd129486e04e6fe69c42a8a3389bb317e4e..11f75575223fbd71c1b5c094562a2505616843e2 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -675,7 +675,7 @@ bool IsAutofillableInputElement(const WebInputElement* element) {
          IsCheckableElement(element);
 }
 
-const base::string16 GetFormIdentifier(const WebFormElement& form) {
+const base::string16& GetFormIdentifier(const WebFormElement& form) {

[vabr (Chromium), 2014/07/11 13:37:43]

Here returning a reference won't work, because the object returned lives on the
local stack and goes out of scope after returning.
Please return a (non-const) string16 by value instead.

[Ilya Sherman, 2014/07/11 19:11:10]

As I mentioned on the bug, the const here is correct.  It prevents a class of
improbable but very surprising code snippets from compiling.

[vabr (Chromium), 2014/07/11 19:24:47]

Thanks for pointing that out.
Let's revert the changes to form_autofill_util.*, then.

[lucinka.brozkova, 2014/07/11 21:05:57]

Done.

   base::string16 identifier = form.name();
   CR_DEFINE_STATIC_LOCAL(WebString, kId, ("id"));
   if (identifier.empty())